Skip to content

Feature/issue 208#210

Merged
dmpas merged 4 commits intoe8tools:developfrom
ava57r:feature/issue-208
Feb 18, 2018
Merged

Feature/issue 208#210
dmpas merged 4 commits intoe8tools:developfrom
ava57r:feature/issue-208

Conversation

@ava57r
Copy link
Copy Markdown
Member

@ava57r ava57r commented Feb 18, 2018

fix #208

@ava57r
Copy link
Copy Markdown
Member Author

ava57r commented Feb 18, 2018

мне нравятся цифры https://travis-ci.org/dmpas/tool1cd/builds/343018504#L712
=) 116% - это круто!

Comment thread src/tests/tool1cd/test_saveconfig.cpp Outdated

WHEN("Выгружаем конфигурацию поставщика") {
path cfpath = boost::filesystem::temp_directory_path() / boost::filesystem::unique_path();
auto supplier_config = base1CD.supplier_configs().front();
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а чо б все не обойти циклом?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тогда мне надо проверить вектор файлов.
тест усложняется.
здесь точно одна конфигурация поставщика, вот и беру первую

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

могу попробовать переписать на проверку всего вектора.
просто пошел по максимально простому пути.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

пошел писать.

@dmpas dmpas merged commit 7c9d0ea into e8tools:develop Feb 18, 2018
@ava57r ava57r deleted the feature/issue-208 branch February 21, 2018 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Неверное владение объектом в SupplierConfigBuilder

2 participants