Skip to content

Conversation

@yamingk
Copy link
Collaborator

@yamingk yamingk commented May 7, 2025

Needs to wait for homestore PR to be merge first: eBay/HomeStore#715

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.69%. Comparing base (0b40663) to head (0a2e9e4).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/volume/volume.cpp 66.66% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   61.68%   62.69%   +1.01%     
==========================================
  Files          15       15              
  Lines         462      504      +42     
  Branches       35       41       +6     
==========================================
+ Hits          285      316      +31     
- Misses        158      166       +8     
- Partials       19       22       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yamingk yamingk merged commit b1d7f4d into eBay:main May 8, 2025
21 checks passed
@yamingk yamingk deleted the yk_fix_test2 branch May 8, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants