Skip to content

Conversation

@JacksonYao287
Copy link
Collaborator

@JacksonYao287 JacksonYao287 commented Apr 28, 2025

now that we have continuous notifications of the last committed lsn, we can always set error info and wait until got the notification of this lsn is committed.

this way, we no longer need to pause statemachine and check whether the last append lsn is committed

@JacksonYao287 JacksonYao287 force-pushed the handle-config-commit-rollback branch from cb745ef to b4b7495 Compare April 28, 2025 07:04
@JacksonYao287
Copy link
Collaborator Author

waiting for this PR to be merged eBay/HomeStore#703

@JacksonYao287 JacksonYao287 changed the title handing config change where we also need to check no_space_left error info handling config change where we also need to check no_space_left error info Apr 28, 2025
@JacksonYao287 JacksonYao287 force-pushed the handle-config-commit-rollback branch from e9e306a to 47decd8 Compare April 29, 2025 07:23
@JacksonYao287 JacksonYao287 force-pushed the handle-config-commit-rollback branch from 47decd8 to 1acfe83 Compare April 29, 2025 07:49
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 58.95%. Comparing base (1746bcc) to head (df34a0c).
Report is 67 commits behind head on main.

Files with missing lines Patch % Lines
...ib/homestore_backend/replication_state_machine.cpp 27.27% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
- Coverage   63.15%   58.95%   -4.21%     
==========================================
  Files          32       33       +1     
  Lines        1900     3009    +1109     
  Branches      204      361     +157     
==========================================
+ Hits         1200     1774     +574     
- Misses        600     1038     +438     
- Partials      100      197      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

xiaoxichen
xiaoxichen previously approved these changes Apr 29, 2025
@JacksonYao287
Copy link
Collaborator Author

@xiaoxichen I have added assert for no_space_left error info, pls take a look. if it looks good to you , free feel to merge it so that it will not block our performance testing

Copy link
Collaborator

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@yuwmao @Besroy pls take a look as well.

Copy link
Contributor

@yuwmao yuwmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JacksonYao287 JacksonYao287 merged commit 3f60adf into eBay:main Apr 30, 2025
25 checks passed
@JacksonYao287 JacksonYao287 deleted the handle-config-commit-rollback branch April 30, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants