-
Notifications
You must be signed in to change notification settings - Fork 17
handling config change where we also need to check no_space_left error info #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handling config change where we also need to check no_space_left error info #293
Conversation
cb745ef to
b4b7495
Compare
|
waiting for this PR to be merged eBay/HomeStore#703 |
e9e306a to
47decd8
Compare
47decd8 to
1acfe83
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
==========================================
- Coverage 63.15% 58.95% -4.21%
==========================================
Files 32 33 +1
Lines 1900 3009 +1109
Branches 204 361 +157
==========================================
+ Hits 1200 1774 +574
- Misses 600 1038 +438
- Partials 100 197 +97 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@xiaoxichen I have added assert for no_space_left error info, pls take a look. if it looks good to you , free feel to merge it so that it will not block our performance testing |
xiaoxichen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yuwmao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
now that we have continuous notifications of the last committed lsn, we can always set error info and wait until got the notification of this lsn is committed.
this way, we no longer need to pause statemachine and check whether the last append lsn is committed