-
Notifications
You must be signed in to change notification settings - Fork 24
Add additional tests for replace member #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a0f0d1d to
cf43db2
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #574 +/- ##
==========================================
+ Coverage 56.51% 63.71% +7.20%
==========================================
Files 108 109 +1
Lines 10300 10696 +396
Branches 1402 1468 +66
==========================================
+ Hits 5821 6815 +994
+ Misses 3894 3201 -693
- Partials 585 680 +95 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally, LGTM!
cf43db2 to
2ee5446
Compare
|
i still dont think skipping |
JacksonYao287
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Add OneMemberRestart , LeaderReplace, OneMemberDown test case.
Comments added in start of unit test