Skip to content

Conversation

@sanebay
Copy link
Contributor

@sanebay sanebay commented Oct 25, 2024

Add OneMemberRestart , LeaderReplace, OneMemberDown test case.
Comments added in start of unit test

@sanebay sanebay force-pushed the replace_member_additional_tests1 branch from a0f0d1d to cf43db2 Compare October 25, 2024 23:49
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.71%. Comparing base (1a0cef8) to head (2ee5446).
Report is 83 commits behind head on master.

Files with missing lines Patch % Lines
...rc/lib/replication/repl_dev/raft_state_machine.cpp 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #574      +/-   ##
==========================================
+ Coverage   56.51%   63.71%   +7.20%     
==========================================
  Files         108      109       +1     
  Lines       10300    10696     +396     
  Branches     1402     1468      +66     
==========================================
+ Hits         5821     6815     +994     
+ Misses       3894     3201     -693     
- Partials      585      680      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally, LGTM!

@sanebay sanebay force-pushed the replace_member_additional_tests1 branch from cf43db2 to 2ee5446 Compare October 31, 2024 22:16
@xiaoxichen
Copy link
Collaborator

i still dont think skipping wait_for_commit() on other leader is right....but as it is an UT, we can revisit if we see it flips.

Copy link
Contributor

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sanebay sanebay merged commit c4efe11 into eBay:master Nov 1, 2024
@sanebay sanebay deleted the replace_member_additional_tests1 branch November 1, 2024 17:22
hkadayam pushed a commit to hkadayam/HomeStore that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants