Add protection for concurrent access to m_down_buffers #577
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #577 +/- ##
===========================================
+ Coverage 56.51% 67.30% +10.79%
===========================================
Files 108 109 +1
Lines 10300 10654 +354
Branches 1402 1454 +52
===========================================
+ Hits 5821 7171 +1350
+ Misses 3894 2787 -1107
- Partials 585 696 +111 ☔ View full report in Codecov by Sentry. |
zhiteng
left a comment
zhiteng
left a comment
There was a problem hiding this comment.
The PR message should be put into commit message as well with some modification, which the reference to eBay internal JIRA isn't suitable for public github.com hosted open source project. My suggestion is to create an issue and refer to that issue instead of JIRA. That way people from outside of eBay may see the entirety of whole issue along with this fix.
|
Linked to #578 |
Signed-off-by: Jilong Kou <jkou@ebay.com>
shosseinimotlagh
left a comment
shosseinimotlagh
left a comment
There was a problem hiding this comment.
LG!
Todo: needs to change to set
Concurrent writes to m_down_buffers may cause data inconsistency. Add a mutex lock to IndexBuffer as well as extracting add/remove operations into member functions to make the vector thread-safe. Signed-off-by: Jilong Kou <jkou@ebay.com>
4 participants
Issue: #578
The
down_bufhas thereal_up_buf(the meta buf) as its up_buffer, but cannot be found in theread_up_buf->m_down_buffers. The inconsistency is caused by unprotected concurrent writes to the vectorm_down_buffers.Add a mutex lock to
IndexBufferas well as extracting add/remove operations into member functions to make the vector thread-safe.