Skip to content

Conversation

@yamingk
Copy link
Contributor

@yamingk yamingk commented May 9, 2025

Change:

  1. expose data service drive type.
  2. fixed one issue to destroy solo repl dev's m_sb during destroy.

Testing

Cross tested with HomeStore consumer

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.99%. Comparing base (1a0cef8) to head (25d68cc).
Report is 192 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/blkdata_svc/blkdata_service.cpp 0.00% 1 Missing ⚠️
src/lib/device/virtual_dev.hpp 0.00% 1 Missing ⚠️
src/lib/logstore/log_dev.cpp 0.00% 1 Missing ⚠️
src/lib/replication/repl_dev/solo_repl_dev.cpp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #718       +/-   ##
===========================================
+ Coverage   56.51%   66.99%   +10.47%     
===========================================
  Files         108      109        +1     
  Lines       10300    11964     +1664     
  Branches     1402     1670      +268     
===========================================
+ Hits         5821     8015     +2194     
+ Misses       3894     3117      -777     
- Partials      585      832      +247     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@sanebay sanebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yamingk yamingk merged commit 9ef938c into eBay:master May 12, 2025
23 checks passed
@yamingk yamingk deleted the yk_report_stats branch May 12, 2025 21:34
@yamingk yamingk linked an issue Jun 18, 2025 that may be closed by this pull request
hkadayam pushed a commit to hkadayam/HomeStore that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose data service device type for HomeStore consumer

4 participants