Fix prefix - reload CompactBitSet #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shosseinimotlagh
changed the title
shosseinimotlagh
changed the title
Collaborator
|
great work! if you can add more details in the commit message that will be helpful for others. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #724 +/- ##
===========================================
+ Coverage 56.51% 67.18% +10.67%
===========================================
Files 108 109 +1
Lines 10300 11975 +1675
Branches 1402 1665 +263
===========================================
+ Hits 5821 8046 +2225
+ Misses 3894 3091 -803
- Partials 585 838 +253 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sanebay
reviewed
May 16, 2025
sanebay
approved these changes
May 16, 2025
hkadayam
pushed a commit
to hkadayam/HomeStore
that referenced
this pull request
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reload CompactBitSet after updating node phys buffer.
When a multiple happens and previous cp X is in flushing state and a node buffer is getting freed, the node buffer is copied for the working cp X+1. This leads to updating the physical node buffer. If there is any class object in a node type, the object still has the previous address which can result in either corruption of flushing buffer or head-use-after-free right after cp X flushing is complete and freeing the dirty index buffer.