Skip to content

Conversation

@yuwmao
Copy link
Contributor

@yuwmao yuwmao commented Jan 28, 2026

  • Add on_clean_replace_member_task callback
  • The current get_replication_status only provides config of peer itself on the follower side. So, add a get_replication_quorum function for the upper layer to correct the membership.

HO PR: eBay/HomeObject#386

- Add on_clean_replace_member_task callback
- The current get_replication_status only provides config of peer itself on the follower side. So, add a get_replication_quorum function for the upper layer to correct the membership.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.21%. Comparing base (1a0cef8) to head (d91eb64).
⚠️ Report is 309 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/replication/repl_dev/raft_repl_dev.cpp 0.00% 27 Missing ⚠️
src/lib/replication/repl_dev/solo_repl_dev.h 0.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
- Coverage   56.51%   48.21%   -8.30%     
==========================================
  Files         108      110       +2     
  Lines       10300    12842    +2542     
  Branches     1402     6164    +4762     
==========================================
+ Hits         5821     6192     +371     
+ Misses       3894     2564    -1330     
- Partials      585     4086    +3501     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Besroy Besroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@yuwmao yuwmao merged commit d607bcc into eBay:master Jan 29, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants