Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Conversation

@LuLaValva
Copy link
Member

Description

  • Marko 4's parser doesn't understand arrow functions passed as attributes unless they're wrapped in parentheses, so all Marko 4 apps that use chips-combobox are broken
  • mtc strips parentheses from attributes so the most straightforward solution is to extract into a variable

@LuLaValva LuLaValva requested a review from agliga February 20, 2025 16:56
@LuLaValva LuLaValva self-assigned this Feb 20, 2025
@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2025

🦋 Changeset detected

Latest commit: 2b1d3a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LuLaValva LuLaValva merged commit 7460452 into master Feb 24, 2025
5 checks passed
@LuLaValva LuLaValva deleted the combobox-arrow-function-bug branch February 24, 2025 18:10
@github-actions github-actions bot mentioned this pull request Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants