-
Notifications
You must be signed in to change notification settings - Fork 30
chore: added visual-html to skin #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a range of HTML test files for visual components in the skin package and updates related snapshot tests. Key changes include new HTML examples for different avatar sizes and alert dialogs, multiple accordion examples (including deprecated, autoCollapse, RTL, and large variations), and an update to the visual-html dependency in package.json.
Reviewed Changes
Copilot reviewed 20 out of 931 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/skin/src/test/Skin/Avatar-*.html | New HTML test files showcasing various avatar states |
| packages/skin/src/test/Skin/Alert Dialog-*.html | New examples testing alert dialog layouts and text spacing |
| packages/skin/src/test/Skin/Accordion/*.html | A comprehensive set of accordion test cases covering various states and configurations |
| packages/skin/src/test.ts | Test file that imports story files and verifies snapshots using visual-html |
| packages/ebayui-core/src/components/ebay-accordion/test/snapshots/test.browser.js.snap | Updated snapshot file for the accordion component |
| package.json | Updated the visual-html dependency from ^2.1.4 to ^2.1.7 |
Comments suppressed due to low confidence (2)
package.json:196
- The visual-html dependency has been updated to ^2.1.7. Please verify that the new version is fully compatible with your visual regression tests and that there are no breaking changes affecting the snapshot outputs.
"visual-html": "^2.1.7",
|
To run individual tests we can use |
|
So currently reworked this to use vitest and visual snapshots provided by them. |
This PR adds visual HTML to skin, and allows all components to be run from storybook.
At the moment, this isn't being run as part of package.json, but it is the first step to getting percy integration.