Skip to content

Conversation

@agliga
Copy link
Collaborator

@agliga agliga commented Jun 18, 2025

This PR adds visual HTML to skin, and allows all components to be run from storybook.
At the moment, this isn't being run as part of package.json, but it is the first step to getting percy integration.

@agliga agliga requested a review from Copilot June 18, 2025 23:14
@changeset-bot
Copy link

changeset-bot bot commented Jun 18, 2025

⚠️ No Changeset found

Latest commit: ce47f82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a range of HTML test files for visual components in the skin package and updates related snapshot tests. Key changes include new HTML examples for different avatar sizes and alert dialogs, multiple accordion examples (including deprecated, autoCollapse, RTL, and large variations), and an update to the visual-html dependency in package.json.

Reviewed Changes

Copilot reviewed 20 out of 931 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/skin/src/test/Skin/Avatar-*.html New HTML test files showcasing various avatar states
packages/skin/src/test/Skin/Alert Dialog-*.html New examples testing alert dialog layouts and text spacing
packages/skin/src/test/Skin/Accordion/*.html A comprehensive set of accordion test cases covering various states and configurations
packages/skin/src/test.ts Test file that imports story files and verifies snapshots using visual-html
packages/ebayui-core/src/components/ebay-accordion/test/snapshots/test.browser.js.snap Updated snapshot file for the accordion component
package.json Updated the visual-html dependency from ^2.1.4 to ^2.1.7
Comments suppressed due to low confidence (2)

package.json:196

  • The visual-html dependency has been updated to ^2.1.7. Please verify that the new version is fully compatible with your visual regression tests and that there are no breaking changes affecting the snapshot outputs.
    "visual-html": "^2.1.7",

@agliga agliga self-assigned this Jun 23, 2025
@agliga
Copy link
Collaborator Author

agliga commented Dec 18, 2025

To run individual tests we can use
npx vitest run -t tooltip (basically run only tests that match the describe().

 Test Files  1 passed (1)
      Tests  15 passed | 973 skipped (988)
   Start at  11:15:31
   Duration  3.53s (transform 0ms, setup 614ms, import 210ms, tests 2.06s, environment 0ms)

@agliga
Copy link
Collaborator Author

agliga commented Dec 19, 2025

So currently reworked this to use vitest and visual snapshots provided by them.
https://vitest.dev/guide/snapshot.html#visual-snapshots
This simplifies the process and allows us to run full visual regression on each PR (which is enabled in this change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants