Skip to content

Conversation

@HenriqueLimas
Copy link
Member

  • Fixes #

Description

  • Set React 19 as minimum version in ui-core-react

@HenriqueLimas HenriqueLimas self-assigned this Jan 2, 2026
Copilot AI review requested due to automatic review settings January 2, 2026 19:08
@changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2026

🦋 Changeset detected

Latest commit: 1610e29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ui-core-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the minimum React version requirement from 16.0.0 to 19.0.0 for the ebayui-core-react package, marking a major breaking change that removes support for React versions 16, 17, and 18.

Key Changes:

  • Updated peer dependency constraints for React and React DOM to require version 19 or higher
  • Simplified the @ebay/skin peer dependency version constraint
  • Added a major version changeset documenting the breaking change

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/ebayui-core-react/package.json Updated peer dependencies to require React 19 and simplified skin version constraint
.changeset/lazy-places-carry.md Added major version changeset documenting removal of React 16/17/18 support

"@ebay/skin": "^19.0.0",
"react": ">= 16.0.0",
"react-dom": ">= 16.0.0"
"@ebay/skin": "^19",
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @ebay/skin version constraint was changed from ^19.0.0 to ^19. While functionally equivalent in most cases, the shorter form ^19 allows any 19.x.x version including 19.0.0-alpha prereleases. Consider keeping the more explicit ^19.0.0 format for consistency and to avoid unintended prerelease matching unless prereleases are intentionally supported.

Suggested change
"@ebay/skin": "^19",
"@ebay/skin": "^19.0.0",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants