This repository was archived by the owner on Feb 16, 2022. It is now read-only.
implement cacheless lodash.get internally #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
lodash.getinternally, and importantly, without cachinglodash.getdependencyContext
@DylanPiercey did some initial investigation around
lodash.gets cache actually doing more harm than good for certain cases. It seemed that the cache required additional garbage collection time, which increased CPU usage across the board. In this PR, I've taken his initial code and made a few adjustments.We will need to rerun the GC/CPU analysis. I'm putting the code here so it's easier to do that. We now also have #12, which we could potentially use for comparison.
Perf data:
Before:
After: