Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Conversation

@agliga
Copy link
Contributor

@agliga agliga commented Nov 13, 2024

Fixes #2493

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Added new common charger directive component

Notes

  • There are currently 4 variations. With and without charger (icon change), and with and without usb pd if there's fast charging or not.

Screenshots

Screenshot 2024-11-13 at 10 28 17 AM

Checklist

  • I verify the build is in a non-broken state

  • I verify all changes are within scope of the linked issue

  • I regenerated all CSS files under dist folder

  • I tested the UI in all supported browsers

  • I did a visual regression check of the components impacted by doing a Percy build and approved the build

  • I tested the UI in dark mode and RTL mode

  • I added/updated/removed Storybook coverage as appropriate

@agliga agliga self-assigned this Nov 13, 2024
@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: e832a0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga agliga force-pushed the charger branch 2 times, most recently from 395184c to 677f974 Compare November 13, 2024 19:01
Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one question about stories.

@agliga agliga merged commit cb7222a into 18.5.0 Nov 14, 2024
@agliga agliga deleted the charger branch November 14, 2024 17:17
@github-actions github-actions bot mentioned this pull request Nov 14, 2024
@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants