Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Conversation

@agliga
Copy link
Contributor

@agliga agliga commented Jan 16, 2025

Fixes #2514

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Did not update date-textbox styles to support floating ui in my initial PR, updated here

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: 4dfbbce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was going to suggest moving the js to the component page itself, but I see Popper is centralized in main.js for broad use across components, so this should be ok.

@agliga agliga merged commit 5a5a45f into 19.0.0 Jan 17, 2025
@agliga agliga deleted the date-textbox-floating-ui branch January 17, 2025 19:48
@github-actions github-actions bot mentioned this pull request Jan 17, 2025
This was referenced Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants