Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Conversation

@ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Feb 10, 2025

Fixes #2466

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Created a new generic and component-agnostic layout grid component that allows for the easy implementation of responsive layouts with multiple components or elements inside.

This component will remove redundancy and CSS duplication across all similar grouped components, such as toggle-button-group.

Screenshots

Unbalanced Layouts (previously)

image

Balanced Layouts (new with this component)

image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I verify the MIND pattern for the component has been created/revised
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: 2b0e4fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ianmcburnie
Copy link
Contributor

Could this potentially replace the aging .field classes? The purpose of those was to provide sensible defaults (in a pre flexbox/grid world) for all the typical form field layouts.

@ArtBlue ArtBlue requested a review from agliga February 11, 2025 18:56
@ArtBlue
Copy link
Contributor Author

ArtBlue commented Feb 11, 2025

Could this potentially replace the aging .field classes? The purpose of those was to provide sensible defaults (in a pre flexbox/grid world) for all the typical form field layouts.

Possibly. It's definitely worth taking a closer look for sure. It would decouple the functional UI (labels, controls, etc.) from the generic/visual UI (layouts).

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it overall looks good. If we are to expand it to field or other elements, we can do it in a followup

@ArtBlue ArtBlue merged commit 097513e into 19.1.0 Feb 12, 2025
@ArtBlue ArtBlue deleted the 2466-layout-new-module branch February 12, 2025 19:29
@github-actions github-actions bot mentioned this pull request Feb 11, 2025
@github-actions github-actions bot mentioned this pull request Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants