Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Conversation

@ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Mar 7, 2025

Fixes #2593

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Fixed print view of layouts by changed @media screen to @media all
  • Fixed page-grid example pages to avoid prod layout breaks

Notes

  1. Visit one of the page grid example pages
  2. Do a print preview
  3. Verify the print preview has the same layout as the page
  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue linked an issue Mar 7, 2025 that may be closed by this pull request
1 task
@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2025

🦋 Changeset detected

Latest commit: 15bc737

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ArtBlue ArtBlue self-assigned this Mar 7, 2025
@ArtBlue ArtBlue requested a review from ianmcburnie March 10, 2025 15:54
LuLaValva
LuLaValva previously approved these changes Mar 10, 2025
Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few comments, but I think you can merge even without addressing

@ArtBlue ArtBlue merged commit cfb2b17 into master Mar 10, 2025
@github-actions github-actions bot mentioned this pull request Mar 10, 2025
@ArtBlue ArtBlue deleted the 2593-page-grid-fix-print-view branch March 10, 2025 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

page-grid: fix print view

3 participants