Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Conversation

@ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Mar 20, 2025

Fixes #2133

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Created Item Tile component
  • Created Item Tile Group component

Notes

Item Tile Group is a very thin component. it does only two things -

  1. Takes in the a11y title for the group of item tiles and sets it in the layout-grid, specifically on <ul aria-label="Items for sale">.
  2. Sets the specific breakpoint rules for how many item-tiles per row at each breakpoint.

Screenshots

image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I verify the markup will not be a breaking change (if not a major release)
  • I verify the MIND pattern for the component has been created/revised
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue self-assigned this Mar 20, 2025
@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2025

🦋 Changeset detected

Latest commit: 117303c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple of minor issues and some naming things

@ArtBlue ArtBlue requested a review from agliga March 21, 2025 18:25
@ArtBlue
Copy link
Contributor Author

ArtBlue commented Mar 21, 2025

@agliga , ok, I think I've resolved everything and cleaned up a few other things. Please take another look.

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, Im fine approving as is, but I would like to simplify the structure slightly if possible (since it would be breaking)

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ArtBlue ArtBlue merged commit 7bf9c1c into 19.2.0 Mar 25, 2025
@ArtBlue ArtBlue deleted the item-tiles-19-2-0 branch March 25, 2025 17:07
This was referenced Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants