-
Notifications
You must be signed in to change notification settings - Fork 68
feat(item-tile,item-tile-group): created new components #2603
Conversation
🦋 Changeset detectedLatest commit: 117303c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agliga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, couple of minor issues and some naming things
|
@agliga , ok, I think I've resolved everything and cleaned up a few other things. Please take another look. |
agliga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last comment, Im fine approving as is, but I would like to simplify the structure slightly if possible (since it would be breaking)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Fixes #2133
Description
Notes
Item Tile Group is a very thin component. it does only two things -
a11ytitle for the group of item tiles and sets it in thelayout-grid, specifically on<ul aria-label="Items for sale">.item-tilesper row at each breakpoint.Screenshots
Checklist