Skip to content

[#23141] Sample ID incorrectly resets when SampleInfo/WriteParams goes out of thread scope#252

Merged
richiware merged 5 commits intomainfrom
feature/sample_id
Sep 30, 2025
Merged

[#23141] Sample ID incorrectly resets when SampleInfo/WriteParams goes out of thread scope#252
richiware merged 5 commits intomainfrom
feature/sample_id

Conversation

@Danipiza
Copy link
Copy Markdown
Contributor

@Danipiza Danipiza commented Aug 20, 2025 •
edited by rsanchez15
Loading

Description

  • Update the functions to be attributes in Python interface files.
  • Added copy constructor in SampleIdentity.i

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Changes are API compatible.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

richiware
richiware requested changes Aug 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@richiware richiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extend copyctor swig argument to other classes in the same situation

Comment thread fastdds_python/src/swig/fastdds/rtps/common/SampleIdentity.i Outdated
Comment thread fastdds_python/src/swig/fastdds/rtps/common/SampleIdentity.i Outdated
Comment thread fastdds_python/src/swig/fastdds/rtps/common/WriteParams.i Outdated
@Danipiza
Copy link
Copy Markdown
Contributor Author

Danipiza commented Sep 22, 2025

Extend copyctor swig argument to other classes in the same situation

Done in e2fe2c7

richiware
richiware requested changes Sep 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@richiware richiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I miss next structures to have the copyctor:

  • Time_t
  • GUID_t
  • SequenceNumber_t

@MiguelCompany MiguelCompany added this to the v2.4.0 milestone Sep 25, 2025
Danipiza and others added 5 commits September 29, 2025 10:19
@Danipiza @richiware
[#23141] First approach
66b70cc 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@Danipiza @richiware
[#23141] Updated SampleIdentity and WriteParams
36010cf 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@Danipiza @richiware
[#23141] Review changes
db370bb 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@Danipiza @richiware
[#23141] Removed unnecessary files
f6be53c 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@richiware
Refs #23141. Add more copyctr
509f848 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 30, 2025
@richiware richiware merged commit 955d458 into main Sep 30, 2025
8 checks passed
@richiware richiware deleted the feature/sample_id branch September 30, 2025 07:18
@rsanchez15 rsanchez15 mentioned this pull request Nov 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richiware richiware richiware approved these changes

@rsanchez15 rsanchez15 rsanchez15 approved these changes

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v2.4.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

4 participants

@Danipiza @richiware @rsanchez15 @MiguelCompany