Skip to content

[eloquent backport] Fix deadlock between PDP and StatefulReader (#871) #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MiguelCompany merged 1 commit into from
Feb 20, 2020
Merged

[eloquent backport] Fix deadlock between PDP and StatefulReader (#871) #1019

MiguelCompany merged 1 commit into from
Feb 20, 2020

Conversation

@sloretz
Copy link
Contributor

@sloretz sloretz commented Feb 19, 2020

This is a cherry-pick of #871 to the ros2-eloquent branch.

@dirk-thomas FYI

@sloretz
Fix deadlock between PDP and StatefulReader (eProsima#871)
7414ec8 
* Fix deadlock between PDP and StatefulReader

This releases the PDP mutex before calling a function that may try to
acquire the mutex on a StatefulReader.

Signed-off-by: Shane Loretz<sloretz@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Removing unnecessary lock().

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
MiguelCompany
MiguelCompany approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MiguelCompany MiguelCompany reopened this Feb 20, 2020
@MiguelCompany
Copy link
Member

MiguelCompany commented Feb 20, 2020 •
edited
Loading

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Failures on flaky tests fixed later than 1.9.3
Warnings on performance tests were fixed later than 1.9.3
Note: We need to update the CI flags for branch ros2-eloquent so performance tests are not run.

@MiguelCompany MiguelCompany merged commit 7212843 into eProsima:ros2-eloquent Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sloretz @MiguelCompany