Skip to content

Comments

Minichallenge 3#1

Merged
eRobles10 merged 10 commits intomasterfrom
minichallenge_3
Apr 13, 2021
Merged

Minichallenge 3#1
eRobles10 merged 10 commits intomasterfrom
minichallenge_3

Conversation

@eRobles10
Copy link
Owner

Update to display videos using youtube API v3, update css and views from previous verison, and add some tests

@eRobles10 eRobles10 merged commit 4cb9885 into master Apr 13, 2021
Comment on lines +24 to +42
test("Ensure that Video Card is rendered", () => {


});

test("Ensure that Thumbnail in Video Card match with the one in the mock item", () => {


});

test("Ensure that Title in Video Card match with the mock item selected", () => {


});

test("Ensure that Title in Video Card match with the mock item selected", () => {


});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment this section if you will add those scenarios in another PR

Comment on lines +1 to +8
describe('Header Test', () => {


test("Ensure all App is getting rendered", () => {


});
}) No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment this test scenario if you are not using it

Comment on lines +1 to +8
describe('App Test', () => {

test("Ensure all videos in the mock file are getting rendered", () => {


});

}) No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment this test scenario if you are not using it

Comment on lines +21 to +34
test("Ensure that main video is rendered", () => {


});

test("Ensure that Title in Video Card match with the mock item selected", () => {


});

test("Ensure that Description is displayed selected", () => {


});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment this tests if you are going to add it in another PR

Comment on lines +21 to +31
test("Ensure that Video Card is rendered", () => {
});

test("Ensure that Thumbnail in Video Card match with the one in the mock item", () => {
});

test("Ensure that Title in Video Card match with the mock item selected", () => {

});

test("Ensure that Title in Video Card match with the mock item selected", () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment this tests if you are going to add in another PR

import styled from 'styled-components';


const MenuButton = styled.button`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component seems to be duplicated from src/components/Header/LoginControl/LoginControl.component.jsx

}

return(
<form onSubmit={onSubmitQuery}>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search method is triggered only once, it is not taking more inputs for search.




const VideoCard =(props) =>{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use destructuring to improve readability on the props.

const VideoCard = ({ id, snippet, setShowDetail }) => {}

`;

function VideoDetail(props){
console.log(props)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove console.log




const VideoList =(props) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to use destructuring on each component you create, it would improve readability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants