Skip to content

Contributors update #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lwasser merged 10 commits into from
Mar 10, 2020
Merged

Contributors update #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8344d56
Merge pull request #1 from earthlab/master
nkorinek Feb 6, 2020
b87394d
Merge pull request #2 from earthlab/master
nkorinek Feb 12, 2020
7cf2703
Merge pull request #3 from earthlab/master
nkorinek Feb 12, 2020
c4d904e
Merge pull request #4 from earthlab/master
nkorinek Feb 13, 2020
c6deb54
Merge pull request #5 from earthlab/master
nkorinek Feb 13, 2020
30b4aa1
Merge pull request #7 from earthlab/master
nkorinek Feb 17, 2020
6ab2486
Merge pull request #8 from earthlab/master
nkorinek Mar 3, 2020
5077e25
Merge pull request #9 from earthlab/master
nkorinek Mar 7, 2020
d7e4d3a
Added contributor rst file and moved that information out of the READ…
nkorinek Mar 7, 2020
e444564
Implemented requested changes to README
nkorinek Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .zenodo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
"name": "Wasser, Leah",
"orcid": "0000-0002-8177-6550"
},
{
"affiliation": "Earth Lab, University of Colorado - Boulder",
"name": "Korinek, Nathan",
"orcid": "0000-0003-0859-7246"
},
{
"name": "LaRocque, Ryan",
"orcid": "0000-0003-2540-1428"
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]
* made `assert_string_contains()` accept correct strings with spaces in them (@nkorinek, #182)
* added contributors file and updated README to remove that information (@nkorinek, #121)

## [0.1.2]
* Adding flake8 for format and other syntax issues! yay! (@lwasser, #195)
Expand Down
25 changes: 4 additions & 21 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,35 +111,18 @@ vt.assert_polygons(polygons_expected=polygons)
Caveats: This repo likely misses edge cases of the many ways matplotlib plots can be created.
Please feel free to submit bugs!


## Active Contributors
Copy link

@lwasser lwasser Mar 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nkorinek my apologies for not being clear. i want to keep the contributors in the readme so take what you did above and move it down here. i wanted to switch my name to the github image and then add your name below it with your github image as well.


- Leah Wasser

## Dev Setup (to be moved to contributing)
Copy link

@lwasser lwasser Mar 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this part moves to contributing .rst as you did


setup the matplotcheck envt

```
conda env create -f environment.yml
conda activate matplotcheck-dev
```

Then setup all of the development requirements.

```
pip install -e .
pip install -r dev-requirements.txt
pre-commit install
```
<a title="Leah Wasser" href="https://www.github.com/lwasser"><img width="60" height="60" alt="Leah Wasser" class="pull-left" src="https://avatars2.githubusercontent.com/u/7649194?s=460&v=4" /></a>
<a title="Nathan Korinek" href="https://www.github.com/nkorinek"><img width="60" height="60" alt="Nathan Korinek" class="pull-left" src="https://avatars3.githubusercontent.com/u/38253680?s=460&v=4" /></a>

## Contributors
Copy link

@lwasser lwasser Mar 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part stays in the readme but let's fix ryan's name. i see this was my mistake!! can you help me fix it?


We've welcome any and all contributions. Below are some of the
contributors to MatPlotCheck.

<a title="Ryan Solvik" href="https://www.github.com/ryla5068"><img width="60" height="60" alt="Kylen Solvik" class="pull-left" src="https://avatars.githubusercontent.com/u/43677611?size=120" /></a>
<a title="Kylen Solvik" href="https://www.github.com/ksolvik"><img width="60" height="60" alt="Kylen Solvik" class="pull-left" src="https://avatars.githubusercontent.com/u/24379590?size=120" /></a>
<a title="Ryan Larocque" href="https://www.github.com/ryla5068"><img width="60" height="60" alt="Ryan Larocque" class="pull-left" src="https://avatars.githubusercontent.com/u/43677611?size=120" /></a>
<a title="Kylen Solvik" href="https://www.github.com/kysolvik"><img width="60" height="60" alt="Kylen Solvik" class="pull-left" src="https://avatars.githubusercontent.com/u/24379590?size=120" /></a>
<a title="Kristen Curry" href="https://www.github.com/kdcurry"><img width="60" height="60" alt="Kristen Curry" class="pull-left" src="https://avatars.githubusercontent.com/u/4032126?size=120" /></a>

## How to Contribute
Copy link

@lwasser lwasser Mar 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section how to contribute stays in the readme as well.

Expand Down