Vector vignette by nkorinek · Pull Request #220 · earthlab/matplotcheck

nkorinek · 2020-03-16T22:54:27Z

Vignette for how to test Vector objects with MatPlotCheck. WIP because I'm trying to troubleshoot one issue with checking points by markersize still.

Updating files

Update setuptools from 42.0.2 to 45.2.0 (earthlab#190)

raster inherits from vector rather than base (earthlab#76)

Allow geodataframes in assert_polygons (earthlab#188)

Updating from master

updating

Add flake8 fix [WIP] (earthlab#199)

Assert string accept spaces (earthlab#205)

update

…al x values causing failure!

nkorinek · 2020-03-16T22:55:14Z

This PR requires that #203 is merged first!

codecov · 2020-03-16T23:17:40Z

Codecov Report

Merging #220 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   79.95%   79.95%           
=======================================
  Files          19       19           
  Lines        1831     1831           
=======================================
  Hits         1464     1464           
  Misses        367      367

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da924a0...da924a0. Read the comment docs.

into vector-vignette

Title assert accepts strings (earthlab#229)

…check into vector-vignette

jlpalomino · 2020-04-10T20:10:49Z

For our documentation, we have verbally discussed changes that will be completed by nkorinek, including the addition of more explanation about the object type that is being tested (e.g. a story about what kind of data is being used and what the test is actually looking for) both at the top of the notebook and in the comments, and a new section at the bottom of the vignette for additional options when using a Jupyter Notebook implementation.

nkorinek · 2020-04-20T18:16:57Z

@jlpalomino ready for review!

jlpalomino

A few minor changes but otherwise looking good!

examples/plot_vector_testing.py

…check into vector-vignette

nkorinek · 2020-04-21T23:03:28Z

@jlpalomino sorry this took so long to get to, but I've added in the changes you requested!

examples/plot_vector_testing.py

jlpalomino · 2020-04-21T23:16:13Z

@nkorinek No worries! And great work on this! Three super small modifications for the last changes.

After you make these small changes, feel free to ping lwasser to let her know that this PR is ready. Not sure if she wanted to take a look before merging. Thanks!

nkorinek · 2020-04-22T20:07:33Z

@lwasser this is done btw!

lwasser · 2020-04-23T15:13:41Z

@jlpalomino you haven't approved this pr. have all of the changes been made to your satisfaction? if so please approve on your end and then i'll have a look!

jlpalomino · 2020-04-23T15:45:53Z

@lwasser Sorry about that! Approval done. It's ready for your review.

CHANGELOG.md

lwasser

just letting ci run one more time and then i can merge!

lwasser · 2020-04-24T20:58:32Z

merging. thank you for your work on this pr @nkorinek @jlpalomino !!

nkorinek and others added 21 commits February 6, 2020 15:04

Merge pull request #1 from earthlab/master

8344d56

Updating files

Merge pull request #2 from earthlab/master

b87394d

Update setuptools from 42.0.2 to 45.2.0 (earthlab#190)

Merge pull request #3 from earthlab/master

7cf2703

raster inherits from vector rather than base (earthlab#76)

Merge pull request #4 from earthlab/master

c4d904e

Allow geodataframes in assert_polygons (earthlab#188)

Merge pull request #5 from earthlab/master

c6deb54

Updating from master

Merge pull request #7 from earthlab/master

30b4aa1

updating

Added a get_points() and assert_points() function to the vector tester.

c1bb42b

Added in get_points() and assert_points() functions with tests

6cd48e3

Added proper documentation

5e6a175

Small fix to please codacy

408ab38

black

8325ed9

Updated changelog

7ac5d41

Merge pull request #8 from earthlab/master

6ab2486

Add flake8 fix [WIP] (earthlab#199)

Fixing merge conflicts

8a2ce1b

Merge pull request #9 from earthlab/master

5077e25

Assert string accept spaces (earthlab#205)

Merge pull request #10 from earthlab/master

4ff1b26

update

Rough draft for bug fix

c75e421

Fixed bug with multiple geometries plotted alongside bug with identic…

075052c

…al x values causing failure!

fixing merge conflict

34838ee

typo

a792725

Created vignette for testing vector object

540f328

nkorinek added 7 commits March 17, 2020 13:02

Fixed small bug with markersize

6876a50

Merge branch 'assert_points' of https://github.com/nkorinek/matplotcheck

81690b5

into vector-vignette

Added fixed test for marker size

3ddf05b

Added small note

62b6b2d

Added comments explaining code

b73e4ef

Merge branch 'assert_points' of https://github.com/nkorinek/matplotcheck

523206d

into vector-vignette

Getting rid of trailing whitespace

ec63ba1

nkorinek and others added 4 commits April 3, 2020 11:55

Merge branch 'master' into vector-vignette

1168298

Merge pull request #17 from earthlab/master

60e57e4

Title assert accepts strings (earthlab#229)

Merge (again)

1613639

Merge branch 'vector-vignette' of https://github.com/nkorinek/matplot…

bb8dcb6

…check into vector-vignette

nkorinek and others added 2 commits April 10, 2020 16:24

Added in changes discussed on github

2c01d02

Merge branch 'master' into vector-vignette

91c3818

jlpalomino suggested changes Apr 20, 2020

View reviewed changes

lwasser added the documentation documentation for the package label Apr 20, 2020

nkorinek added 2 commits April 21, 2020 17:02

Added in formatting changes requested on github

3b4912a

Merge branch 'vector-vignette' of https://github.com/nkorinek/matplot…

a28866c

…check into vector-vignette

jlpalomino reviewed Apr 21, 2020

View reviewed changes

examples/plot_vector_testing.py Outdated Show resolved Hide resolved

jlpalomino reviewed Apr 21, 2020

View reviewed changes

examples/plot_vector_testing.py Outdated Show resolved Hide resolved

jlpalomino reviewed Apr 21, 2020

View reviewed changes

examples/plot_vector_testing.py Outdated Show resolved Hide resolved

Fixing a final few typos!

bde5605

jlpalomino approved these changes Apr 23, 2020

View reviewed changes

Merge branch 'master' into vector-vignette

2edfabc

lwasser reviewed Apr 24, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Leah Wasser added 2 commits April 24, 2020 13:31

Update CHANGELOG.md

cf5c83b

minor fix

da924a0

lwasser approved these changes Apr 24, 2020

View reviewed changes

lwasser merged commit 38711b1 into earthlab:master Apr 24, 2020

nkorinek mentioned this pull request Apr 30, 2020

Create a vignette for testing vector plots #208

Closed

Conversation

nkorinek commented Mar 16, 2020

Uh oh!

nkorinek commented Mar 16, 2020

Uh oh!

codecov bot commented Mar 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jlpalomino commented Apr 10, 2020

Uh oh!

nkorinek commented Apr 20, 2020

Uh oh!

jlpalomino left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nkorinek commented Apr 21, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jlpalomino commented Apr 21, 2020

Uh oh!

nkorinek commented Apr 22, 2020

Uh oh!

lwasser commented Apr 23, 2020

Uh oh!

jlpalomino commented Apr 23, 2020

Uh oh!

Uh oh!

lwasser left a comment

Choose a reason for hiding this comment

Uh oh!

lwasser commented Apr 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Mar 16, 2020 •

edited

Loading