-
Notifications
You must be signed in to change notification settings - Fork 11
Line limits assertion fix #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
8344d56
Merge pull request #1 from earthlab/master
nkorinek b87394d
Merge pull request #2 from earthlab/master
nkorinek 7cf2703
Merge pull request #3 from earthlab/master
nkorinek c4d904e
Merge pull request #4 from earthlab/master
nkorinek c6deb54
Merge pull request #5 from earthlab/master
nkorinek 30b4aa1
Merge pull request #7 from earthlab/master
nkorinek 6ab2486
Merge pull request #8 from earthlab/master
nkorinek 5077e25
Merge pull request #9 from earthlab/master
nkorinek 4ff1b26
Merge pull request #10 from earthlab/master
nkorinek de25545
Merge pull request #11 from earthlab/master
nkorinek 2f2f01d
Merge pull request #12 from earthlab/master
nkorinek 031a710
Merge pull request #13 from earthlab/master
nkorinek 7bb3216
Merge pull request #14 from earthlab/master
nkorinek cd169d3
Merge pull request #15 from earthlab/master
nkorinek e0e3c34
Merge pull request #16 from earthlab/master
nkorinek 60e57e4
Merge pull request #17 from earthlab/master
nkorinek 2050f4b
Fixed bug with how line limits are checke
nkorinek 5569d18
Merge pull request #18 from earthlab/master
nkorinek 90b8128
Update setuptools from 42.0.2 to 45.2.0 (#190)
pyup-bot c96321c
raster inherits from vector rather than base (#76)
8e26cba
Allow geodataframes in assert_polygons (#188)
nkorinek 49c4c24
fixing a few syntax errors (#194)
da32ef9
update changelog for release
f842822
Bump version: 0.1.1 → 0.1.2
eee471f
Add flake8 fix [WIP] (#199)
nkorinek 77e8f76
Assert string accept spaces (#205)
nkorinek 99e961a
Update codecov to 2.0.16 (#202)
pyup-bot 3c37b7d
Contributors update (#213)
nkorinek d2dfa5a
Update setuptools from 45.2.0 to 46.0.0 (#215)
pyup-bot 6b142e8
Add Assert points function & cleanup duplicate methods (#203)
nkorinek 7ea9490
Update pytest from 5.3.5 to 5.4.1
pyup-bot a782271
merge
nkorinek e7b4652
Additional vector tests (#212)
nkorinek 0f2fc16
Add tests to the Autograde module (#224)
nkorinek 27251c3
Hist bin midpoints (#204)
nkorinek f3c384f
Update setuptools from 46.1.1 to 46.1.3 (#231)
pyup-bot 654b3d1
Title assert accepts strings (#229)
nkorinek 34e20da
M2r remove (#247)
nkorinek eb4c2d8
merge
nkorinek 3f07d9b
# This is a combination of 2 commits.
pyup-bot beae1b5
Updating in order to squash commits!
nkorinek bfc3321
merge
nkorinek 44f0c3c
Merge branch 'master' into regression-asssert
66b8206
fix copyright on docs (#244)
63fa4e0
Add pillow (#254)
d8e08c4
Merge branch 'master' into regression-asssert
d8b99e3
Fixed issue with new way of checking that the data is covered by the …
nkorinek 5873fb6
Changelog update
nkorinek 5756fa6
merge
nkorinek f52150a
Merge
nkorinek 5f0fd98
Merge branch 'earthlab-master'
nkorinek efab5a2
Changelog to rst (#267)
nkorinek a7dfdc7
setup greetings! (#257)
cb9b6ad
update
nkorinek 76648fd
Added comment to clarify changes
nkorinek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| name: Greetings | ||
|
|
||
| on: [pull_request, issues] | ||
|
|
||
| jobs: | ||
| greeting: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/first-interaction@v1 | ||
| with: | ||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
| issue-message: 'Message that will be displayed on users'' first issue' | ||
| pr-message: 'Message that will be displayed on users'' first pr' |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| MatPlotCheck Release Notes | ||
| ========================== | ||
|
|
||
| All notable changes to this project will be documented in this file. | ||
|
|
||
| The format is based on `Keep a Changelog <https://keepachangelog.com/en/1.0.0/>`_, and this project adheres to | ||
| `Semantic Versioning <https://semver.org/spec/v2.0.0.html>`_. | ||
|
|
||
| Unreleased | ||
| ---------- | ||
|
|
||
| - Changed how `assert_lines` checks the limits of lines (@nkorinek, #243) | ||
| - Changed changelog to an rst file. (@nkorinek, #266) | ||
| - Add a vignette for testing vector data plots. (@nkorinek, #208) | ||
| - Add ``pillow`` as a dev requirement (@lwasser, #253) | ||
| - Removed the ``m2r`` package from MatPlotCheck (@nkorinek, #247) | ||
| - Made ``assert_string_contains()`` accept a string instead of a list | ||
| (@nkorinek, #53) | ||
| - Added functions to get and assert the midpoint values of bins in a | ||
| histogram (@nkorinek, #184) | ||
| - Created tests for the autograde module (@nkorinek, #105) | ||
| - Created tests for the vector module (@nkorinek, #209) | ||
| - Created functions to test point geometries in VectorTester | ||
| (@nkorinek, #176) | ||
| - made ``assert_string_contains()`` accept correct strings with spaces | ||
| in them (@nkorinek, #182) | ||
| - added contributors file and updated README to remove that information | ||
| (@nkorinek, #121) | ||
|
|
||
| 0.1.2 | ||
| ----- | ||
|
|
||
| - Adding flake8 for format and other syntax issues! yay! (@lwasser, | ||
| #195) | ||
| - Created a vignette covering the testing of histograms (@ryla5068, | ||
| #149) | ||
| - Created ``get_plot_image()`` function for the RasterTester object | ||
| (@nkorinek, #192) | ||
| - Allowed ``assert_polygons()`` to accept GeoDataFrames and added tests | ||
| (@nkorinek, #175) | ||
| - raster test inherits from vector to allow for multi layer plot | ||
| testing (@lwasser, #75) | ||
|
|
||
| 0.1.1 | ||
| ----- | ||
|
|
||
| - Added test for bin heights of histograms (@ryla5068, #124) | ||
| - Added support for overlapping histograms in histogram tests | ||
| (@ryla5068, #123) | ||
|
|
||
| 0.1.0 | ||
| ----- | ||
|
|
||
| - Created a vignette covering base plot tester functionality | ||
| (@ryla5068, #122) | ||
| - fix pip version to ensure pyproj installs in black tox envt | ||
| (@lwasser, #144) | ||
| - Changed ``get_caption()`` to return a string (@ryla5068, #125) | ||
| - Updated ``assert_xlabel_ydata()`` to support pulling text from | ||
| x-labels (@ryla5068, #125) | ||
| - Fixed ``assert_xydata()`` incorrectly failing on some floating point | ||
| numbers (@ryla5068, #124) | ||
| - Updated all string content assertions in base to use the same syntax | ||
| (@ryla5068, #132) | ||
| - Moved tests for titles to ``test_base_titles.py`` (@ryla5068, #115) | ||
| - Created ``test_base_data.py`` for data tests (@ryla5068, #114) | ||
| - Added custom error messages to all assert functions in base module | ||
| (@ryla5068, #106) | ||
| - Added all missing docstrings to base module and updated existing ones | ||
| (@ryla5068, #102) | ||
| - Added significant test coverage to base module (@ryla5068, #101) | ||
| - Replaced references to EarthPy in CONTRIBUTING.rst (@ryla5068, #100) | ||
| - Add tests for raster module (@kysolvik, #32) | ||
| - Added tests for base module – legend check methods (@kysolvik, #38) | ||
| - Added tests for base modules – axis check methods (@kysolvik, #37) | ||
| - Add conftest.py to centralize pytest fixtures (@kysolvik, #35) | ||
| - Fix issue with pip 19.1 breaking appveyor build (@kysolvik, #46) | ||
| - Fix Python version mismatch in pre-commit hook vs dev environment | ||
| (@kysolvik, #31) | ||
| - Adding cross platform builds to CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| .. include:: ../CHANGELOG.rst |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nkorinek can you please add a comment here that explains how this fixes this issue. i understand the issue at a high level. so what if the data have a few extreme edge cases outlier points. and the regression line only fits to 3/4 of the data or 1/2 of the data. will this fail? i think i just need a bit more clarification
did we discuss making the data limits of a line optional? that could be something else to consider OR creating a regression line and provided it to the method. i just want to talk this through a bit more so i understand and i want the code to have a comment for the same reason. thank you again!