Absolute tolerance for assert_bin_values#272
Merged
lwasser merged 7 commits intoearthlab:masterfrom May 7, 2020
Merged
Conversation
Contributor
Author
|
Sorry to open up a new PR. Made it easier for me to add the changes in. |
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
==========================================
+ Coverage 79.95% 79.96% +0.01%
==========================================
Files 19 19
Lines 1831 1832 +1
==========================================
+ Hits 1464 1465 +1
Misses 367 367
Continue to review full report at Codecov.
|
lwasser
reviewed
May 7, 2020
lwasser
reviewed
May 7, 2020
|
i've made a few spelling corrections @nkorinek this can be merged once CI is happy again. THANK YOU!! |
lwasser
approved these changes
May 7, 2020
Contributor
Author
|
@lwasser passed! |
|
yay merging. thanks @nkorinek !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @lwasser I added in changes to make the docs run on @ryla5068 's PR. Hopefully this is good to merge after this!
addresses #157