Skip to content

Add autograde module with wrapper functions for test results#93

Merged
lwasser merged 12 commits intoearthlab:masterfrom
jlpalomino:master
Sep 25, 2019
Merged

Add autograde module with wrapper functions for test results#93
lwasser merged 12 commits intoearthlab:masterfrom
jlpalomino:master

Conversation

@jlpalomino
Copy link
Member

@lwasser @kcranston This PR adds the new autograde module containing the wrapper functions that were previously including in the notebooks that are tested with matplotcheck functions.

@codecov
Copy link

codecov bot commented Aug 17, 2019

Codecov Report

Merging #93 into master will decrease coverage by 1.2%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   59.25%   58.04%   -1.21%     
==========================================
  Files          13       14       +1     
  Lines        1205     1230      +25     
==========================================
  Hits          714      714              
- Misses        491      516      +25
Impacted Files Coverage Δ
matplotcheck/autograde.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76a5eb...b225e51. Read the comment docs.

Copy link

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlpalomino please remember how we crafted docstrings for earthpy. we will follow the same standards here. it all renders in the RTD build so i'm really surprised that your build actually ran locally with the missing - (unless my eye isn't catching things right?? ping me when this is fixed.

def run_test(
func,
points,
*args,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kcranston should args come after the correct_message and error message parameters in the function definition?
or is it better to break them up as they are here?

@lwasser lwasser changed the title Add autograde module with wrapper functions for test results [WIP] Add autograde module with wrapper functions for test results Sep 25, 2019
@lwasser lwasser changed the title [WIP] Add autograde module with wrapper functions for test results Add autograde module with wrapper functions for test results Sep 25, 2019
@lwasser
Copy link

lwasser commented Sep 25, 2019

ok merging this and will revisit to add tests and documentation later.

@lwasser lwasser merged commit 9e4460c into earthlab:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants