-
Notifications
You must be signed in to change notification settings - Fork 307
Update Clang easyblock for fixed 'finalpath' source attributes #3961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Update Clang easyblock for fixed 'finalpath' source attributes #3961
Conversation
|
Failing Clang 18 uses LLVM easyblock and fails in tests, so unrelated Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 21 out of 22 (16 easyconfigs in total) |
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 17 out of 17 (16 easyconfigs in total) |
|
@Flamefire Isn't this an indication that merging easybuilders/easybuild-framework#4922 would introduce a breaking change? |
In some rare cases yes. I mention that in easybuilders/easybuild-framework#4922 (comment) There shouldn't be much that does this gymnastics the Clang easyblock does to workaround the bug that is fixed by 4922 |
(created using
eb --new-pr)The Clang easyblock has a workaround for finding the final paths (i.e. the folder that was contained in each source archive) by using globs.
With easybuilders/easybuild-framework#4922 this becomes unnecessary and even fails because it will e.g. look in the wrong folder and append the finalpath to itself:
builddir/compiler-rt-xxx/compiler-rt-xxxWe don't need that logic anymore as we can simply use the
finalpathof each source directly.Requires