fix use of --module-only on existing installations without write permissions#3659
Merged
smoors merged 8 commits intoeasybuilders:developfrom Apr 28, 2021
Merged
Conversation
Member
Author
|
The PR keeps previous behaviour but makes it so that not having the permissions is no longer fatal |
Contributor
|
@ocaisa do you think it's doable/useful to make a test for this? |
Member
Author
|
@smoors I was afraid someone was going to ask that, I'll see if I can figure it out |
added 2 commits
April 28, 2021 12:13
…a/easybuild-framework into module_only_rebuild_no_write_perms
Member
Author
|
@smoors The test I added fails on current |
Contributor
|
Going in, thanks @ocaisa! |
boegel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While attempting to rebuild a module tree from EESSI, I realised there are a couple of barriers in the code right now that don't permit this. As things currently stand
--module-onlyrequires write permissions on the existing installation (for log files and other goodies), this PR fixes this.