Include full shell command that failed in raised error #5074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to quickly inspect the command in the log, especially in test reports.
Member
|
The full command can be quite long, that's exactly why we don't fully include it anymore since EasyBuild v5.0 |
Contributor
Author
|
Makes sense for See https://gist.github.com/boegelbot/276c79e4105f6ed3d4cb633010ef30b3 for the motivation |
Member
That makes sense I guess, since the full command that was run is quite far away from the error being logged, since the command output is in between |
Contributor
Author
|
Done. Did the same for the failing shell command in tests |
Flamefire
force-pushed
the
shell-cmd-error
branch
from
cd3c7a2 to
8f5dc07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to quickly inspect the command in the log, especially in test reports.