Extend list of easyconfig parameters that extensions should not inherit #5075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not make sense for extensions to inherit source(-likes), patches or checksums from the parent easyconfig. Especially the `sources` won't be used anyway, so reset those to the defaults to avoid confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not make sense for extensions to inherit source(-likes), patches or checksums from the parent easyconfig.
Especially the
sourceswon't be used anyway, so reset those to the defaults to avoid confusion.self.srcis set by usingext['src']set bycollect_exts_file_infopossibly based onoptions['sources']I found this while handling the case where
cratesfor a Cargo extension were found which is an error: They would be unused.However they were not set for the extension but in the parent easyconfig.
More general: Most easyconfig parameters should not be inherited for extensions.
Do we actually want to inherit any parameters at all? If so which? Should we just annotate those and reset or remove the rest?