Open
Conversation
OlegLustenko
requested changes
Sep 17, 2018
Member
OlegLustenko
left a comment
OlegLustenko
left a comment
There was a problem hiding this comment.
Есть несколько невыполненных критериев у этого домашнего:
- При вводе в SearchComponent видео не запрашиваются с сервера
- Запрашиваемые видео не передаются на панель справа
- И в продолжении естественно при клике на сайд-баре(панели справа), главное видео не изменяется.
Если у тебя есть вопросы о том, как это сделать, пиши в скайпе, я с радостью тебе отвечу
| ) | ||
| })} | ||
| </ul> | ||
| // {/*<ul className="col-md-4 list-group">*/} |
Member
There was a problem hiding this comment.
please remove commented code, it makes hard to understand after sometime is that code required or not
| //console.log('1', data); | ||
| //console.log('2', data[0].snippet.thumbnails.default.url); | ||
| data.map(elem => { | ||
| arrUrlImg.push(elem.snippet.thumbnails.default.url); |
Member
There was a problem hiding this comment.
здесь нужен setState, чтобы был вызван render, иначе пробрасываться ниже ничего не будет
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.