Incorrectly Ignored User Classes

[barreeeiroo]

This is probably kind of a niche issue... I was trying to integrate Ebean Agent using Ant into the App Inventor project, and found a very interesting bug...

Ebean Agent currently ignores "smartly" many package names known to be utilities through the https://github.com/ebean-orm/ebean-agent/blob/master/ebean-agent/src/main/java/io/ebean/enhance/common/IgnoreClassHelper.java file.
However, App Inventor uses the com.google.appinventor.* package as the user defined root package.

This causes Ebean Agent to not recognize nor enhance any of the classes there, despite explicitly told to. After moving only the entity classes to a different package out of com.google.*, it works fine.

Would it be possible to not ignore the classes, if they are explicitly passed as package filter?

    <taskdef
      name="ebeanEnhance"
      classname="io.ebean.enhance.ant.AntEnhanceTask"
      classpath="${lib.dir}/postgres/ebean-agent-16.1.1.jar"/>
    <ebeanEnhance
      classSource="${AiServerLib-class.dir}/"
      packages="com/google/appinventor/server/storage/database/postgres/**"  <!-- This should take prio over the ignored com.google -->
      transformArgs="debug=10" />

[rbygrave]

I have released the fix in version ebean-agent-16.1.2-RC, if you would like to try that and confirm that works as expected.

Thanks, Rob.

[barreeeiroo]

Thanks a lot for the quick fix @rbygrave! Sure, I'll test it out later today.

Do you happen to have a built JAR of this version? Otherwise I can build it myself later.

[rbygrave]

Yes, the jar is in maven central - https://repo1.maven.org/maven2/io/ebean/ebean-agent/16.1.2-RC1/

[barreeeiroo]

Oh, sorry, missed it (I just looked into the landing page and it was not listed: https://mvnrepository.com/artifact/io.ebean/ebean-agent).

So, for some reason, it's not running anymore. This doesn't give any output in ant:

    <taskdef
      name="ebeanEnhance"
      classname="io.ebean.enhance.ant.AntEnhanceTask"
      classpath="${lib.dir}/postgres/ebean-agent-16.1.2-RC1.jar"/>
    <ebeanEnhance
      classSource="${AiServerLib-class.dir}/"
      packages="${appinventor.pkg}/**"
      transformArgs="debug=10" />

However, rolling back to 16.1.1 gives some output that is indeed running. Could it be because we are appending the packages and transformer args using , instead of ;? https://github.com/ebean-orm/ebean-agent/pull/230/files#diff-28adf9029f32958e40779c22a0214630289740fb4e29bd440496c17420f14fe7R61

Also, if I don't have the packages argument, it now throws a NPE (which was not present before). It happens in line 59 of AntEnhanceTask: https://github.com/ebean-orm/ebean-agent/pull/230/files#diff-28adf9029f32958e40779c22a0214630289740fb4e29bd440496c17420f14fe7R59.

[barreeeiroo]

I've just raised #231 fixing all the issues:

• The NPE was occurring because of the null value in packages
• The "not running at all" issue was occurring because of the , instead of ; when appending the args
• The still ignored classes issue was occurring because of a (probably?) wrong implementation of isIgnoreClass in EnhanceContext:
  • If no packages were passed, then it was indeed only excluding the hardcoded list.
  • However, if packages were defined, it was still falling back to the list even in non-ignored cases.
  • I've changed this behaviour to, if there is a package filter in place, early quit by evaluating the content of this filter (and don't falling back to the ignored classes).

Tested the fix by locally building the JAR and:

• If no packages are passed, no NPE is thrown
• If no packages are passed, all contents in com.google.appinventor were ignored, even legitimate Entity classes (current behaviour, as it falls back into the hardcoded ignored packages list matching com.google as ignored)
• If packages is passed, then it actually scans correctly for the packages inside com.google.appinventor and enhances them

[rbygrave]

Thanks. I've release 16.1.2-RC2 to central, so you can confirm against that version.

[barreeeiroo]

Just tested and working as intended, thanks for the quick publish! When is it going to be available as 16.1.3 (just to not keep having a rc version)?