Skip to content

support J1939 in fibex as manufacturer extension #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebroecker merged 2 commits into from
Mar 3, 2026
Merged

support J1939 in fibex as manufacturer extension #901

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94554ff
support J1939 in fibex as manufacturer extension
malilaroussi Feb 26, 2026
5338355
add frame Type
malilaroussi Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/canmatrix/formats/fibex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,8 @@ def create_frame_element(parent, frame, prefix=""):
create_sub_element_fx(frame_element, "BYTE-LENGTH", str(frame.size))
if frame.attribute("NmAsrMessage") and frame.attribute("NmAsrMessage").lower() == "yes":
create_sub_element_fx(frame_element, "FRAME-TYPE", "NM")
elif (frame.is_j1939):
create_sub_element_fx(frame_element, "FRAME-TYPE", "J1939")
else:
create_sub_element_fx(frame_element, "FRAME-TYPE", "APPLICATION")

Expand Down Expand Up @@ -179,7 +181,7 @@ def create_frame_triggering(parent, frame, prefix=""):
# Frame reference
frame_ref = create_sub_element_fx(frame_triggering, "FRAME-REF")
frame_ref.set("ID-REF", f"{prefix}FRAME_{frame.name}")

# CAN-FD behavior (if applicable)
if frame.is_fd:
create_sub_element_fx(frame_triggering, "CAN-FRAME-TX-BEHAVIOR", "CAN-FD")
Expand Down
Loading