replace deprecated contains with includes#456
Merged
eventualbuddha merged 1 commit intoebryn:masterfrom Jul 24, 2017
Merged
Conversation
GavinJoyce
force-pushed
the
gj/replace-deprecated-contains
branch
from
24808a4 to
3db88a3
Compare
This was referenced Feb 20, 2017
|
Would love to see this merged! |
Collaborator
Author
|
@ebryn might it be possible to either merge this and other valid PRs or perhaps give commit rights to someone else who can? Thanks |
|
|
||
| equal(post.get('author'), null); | ||
| deepEqual(post.toJSON(), {id: 1, author_id: null}); | ||
| deepEqual(post.toJSON(), {id: 1, author_id: undefined}); |
Collaborator
There was a problem hiding this comment.
Why was this needed?
Collaborator
Author
There was a problem hiding this comment.
@eventualbuddha I'm not sure what change in Ember resulted in this change. I'll track it down
Collaborator
Author
There was a problem hiding this comment.
There seems to have been a change within Ember between 2.0 and 2.8 which looks like a bug fix:
2.0:
2.8:
Collaborator
Author
|
@eventualbuddha perhaps you might be able to review this? LMK if you can't and I'll try find someone else |
Collaborator
|
Ping @GavinJoyce |
Collaborator
Author
|
@eventualbuddha I've added some context to the reason that the test change was needed above. Good to merge? |
Collaborator
|
Thanks @GavinJoyce! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.8.3)containswithincludesI'll address the
getOwnerdeprecations once this has merged