Add support for EC-Lab v11.50 (rebased)#97
Conversation
chatcannon
force-pushed
the
JhonFlash-master
branch
from
d6c8c0c to
6a96146
Compare
Few modifications in the VMPdata_dtype_from_colIDs Added new headers VMPmodule_hdr_v2 Modified MPRfile initialization Includes squashed linting fixes by @ml-evs
chatcannon
force-pushed
the
JhonFlash-master
branch
from
6a96146 to
77d5629
Compare
JhonFlash3008
left a comment
JhonFlash3008
left a comment
There was a problem hiding this comment.
All the changes are ok
|
Sorry for the mess with the formatting. In the future I'll make sure to submit in unix formatting. About the Black autoformat, if you don't want I can get rid of it when I work on this project |
|
@chatcannon could we hold off a day or two more? I've been sent a load of example files now that the ECLab "upgrade" is rolling out in our lab, some of them don't contain the parsed data I would expect and as of right now I haven't been able to debug why yet. Hoping to grab some time later today or tomorrow to try again with the latest state of this PR. |
ml-evs
left a comment
ml-evs
left a comment
There was a problem hiding this comment.
Okay, had time to investigate and it was a "me problem", all the tests files I was provided now work well with this PR! No real comments on the code itself; if breaking changes to the MPR format becomes a common occurrence then we might have to restructure along the more automated lines discussed in the issue, but this is good for now.
The only change I had to make downstream to get essentially the same response back from this version of galvani and the last is that the column name for dQ/mA.h changes to dq/mA.h, even for older MPR files. Perhaps @chatcannon could just verify if this is necessary before merging (I've left a comment at the point where this changed in the code).
Either way, thanks @JhonFlash3008 for making the time to contribute this back, and @chatcannon for guidance!
Add support for EC-Lab v11.50 Rebased from echemdata#95 by @JhonFlash3008
3 participants
A rebased version of #95 with the CRLF changes undone and the black formatting split to a separate commit.
@JhonFlash3008 can you check to see if this is what you wanted?
Closes #87.