Skip to content

fix: spec_version & version from modified/created#240

Merged
eric-eclecticiq merged 12 commits into
eclecticiq:masterfrom
MagsenAbbeThales:master
Dec 15, 2025
Merged

fix: spec_version & version from modified/created#240
eric-eclecticiq merged 12 commits into
eclecticiq:masterfrom
MagsenAbbeThales:master

Conversation

@MagsenAbbeThales
Copy link
Copy Markdown
Contributor

@MagsenAbbeThales MagsenAbbeThales commented Sep 7, 2022

Motivation

fix: version from modified/created issue

Solution

Define the version as follow:

  1. Use modified (as before)
  2. Fallback to created as requested by TAXII2 specs
  3. If none is present, raise an exception

@MagsenAbbeThales
Copy link
Copy Markdown
Contributor Author

@erwin-eiq could you approve test actions please?

eric-eclecticiq

This comment was marked as outdated.

@eric-eclecticiq eric-eclecticiq requested a review from saaj December 11, 2025 09:49
Comment thread opentaxii/taxii2/utils.py
Comment thread opentaxii/taxii2/utils.py Outdated
Comment thread tests/taxii2/test_taxii2_sqldb.py Outdated
@eric-eclecticiq eric-eclecticiq requested a review from saaj December 11, 2025 18:56
Comment thread opentaxii/taxii2/utils.py Outdated
Comment thread tests/taxii2/test_taxii2_sqldb.py
@eric-eclecticiq eric-eclecticiq merged commit 6d3f1e1 into eclecticiq:master Dec 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants