Skip to content

Fix error for admin account creation in opentaxii-create-account command#273

Closed
meetghodasara-crest wants to merge 1 commit into
eclecticiq:masterfrom
meetghodasara-crest:bugfix/create-admin-account-command
Closed

Fix error for admin account creation in opentaxii-create-account command#273
meetghodasara-crest wants to merge 1 commit into
eclecticiq:masterfrom
meetghodasara-crest:bugfix/create-admin-account-command

Conversation

@meetghodasara-crest
Copy link
Copy Markdown

Fixed opentaxii-create-account command to support admin argument.

@eric-eclecticiq
Copy link
Copy Markdown
Contributor

Great thank you for the improvement. However, is_admin is not part of the base interface. Could you align OpenTAXIIAuthAPI.create_account to also provide is_admin as a parameter and update the function documentation ?

Then it would be good to be merged.

@eric-eclecticiq eric-eclecticiq self-requested a review November 13, 2025 11:40
Copy link
Copy Markdown
Contributor

@eric-eclecticiq eric-eclecticiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests must be updated as well.

@eric-eclecticiq
Copy link
Copy Markdown
Contributor

Fixed by #294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants