fix: allow empty predicate in query APIs#54
Open
fulviocazzanti wants to merge 1 commit intomainfrom
Open
Conversation
An empty, whitespace-only, or omitted predicate is now treated as a match-all filter instead of returning a 400 error. This makes the API more intuitive: omitting the predicate means "return all results" within the bounds of offset/limit pagination. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParsePredicatereturnsMatchAllPredicatefor empty/whitespace input (early return before ANTLR parsing)required:"true"tag from thePredicatefield in theQuerymodelCloses #15
Test plan
TestParse_EdgeCases— empty string and whitespace returnMatchAllPredicateTestParseTrueKeyword— existingtruekeyword behavior preservedgo test ./common/... ./pmanager/... ./tmanager/...)🤖 Generated with Claude Code