feat: set sane default values for API fields#56
Open
fulviocazzanti wants to merge 1 commit intomainfrom
Open
Conversation
Make State and StateTimestamp optional in NewCell and DeployableEntity DTOs. When omitted, NewAPICell now defaults State to "initial" and StateTimestamp to the current time (UTC). Remove required:"true" tags from server-generated fields (Entity.ID, Entity.Version) since these are always set by the server. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewCell.Statedefaults to"initial"when omittedNewCell.StateTimestampdefaults totime.Now().UTC()when omittedrequired:"true"tags from server-generated fields (Entity.ID,Entity.Version) and fromDeployableEntitystate fieldsomitemptytoNewCell.StateandNewCell.StateTimestampJSON tagsThis makes the API easier to use by not requiring clients to provide values that the server can sensibly default.
Closes #17
Test plan
TestNewAPICell_Defaults— verifies State defaults toinitialand StateTimestamp defaults to nowTestNewAPICell_ExplicitValues— verifies explicit values are preserved🤖 Generated with Claude Code