Skip to content

Conversation

@sleshchenko
Copy link
Member

@sleshchenko sleshchenko commented Apr 5, 2021

What does this PR do?

This PR finalized workspace to devworkspace renaming.
In addition, it also adapts to newer DevWorkspace Client where Che API is introduced + client is initialized in a different way.

What issues does this PR fix or reference?

It's done in the scope of devfile/devworkspace-operator#321.

It depends on che-incubator/devworkspace-client#19
⚠️ After ^ is merged, dependencies should be updated and it should fix PR checks.

Release Notes

Docs PR

@sleshchenko sleshchenko force-pushed the workspace2devworkspace branch from ec776e2 to 1a5679e Compare April 8, 2021 08:58
@sleshchenko sleshchenko force-pushed the workspace2devworkspace branch from 1a5679e to 1523098 Compare April 8, 2021 09:05
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #205 (1523098) into master (345d590) will increase coverage by 0.01%.
The diff coverage is 26.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   50.40%   50.41%   +0.01%     
==========================================
  Files         121      121              
  Lines        4482     4483       +1     
  Branches      740      740              
==========================================
+ Hits         2259     2260       +1     
  Misses       1997     1997              
  Partials      226      226              
Impacted Files Coverage Δ
src/services/helpers/devworkspace.ts 23.07% <0.00%> (ø)
...rc/services/workspace-client/devWorkspaceClient.ts 18.60% <30.76%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345d590...1523098. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 8, 2021

Docker image build succeeded: docker.io/maxura/che-server:che-dashboard-pull-205

1 similar comment
@github-actions
Copy link

github-actions bot commented Apr 8, 2021

Docker image build succeeded: docker.io/maxura/che-server:che-dashboard-pull-205

@sleshchenko sleshchenko merged commit a8aa568 into master Apr 8, 2021
@sleshchenko sleshchenko deleted the workspace2devworkspace branch April 8, 2021 13:20
@che-bot che-bot added this to the 7.29 milestone Apr 8, 2021
@che-bot
Copy link
Contributor

che-bot commented Apr 8, 2021

❌ E2E dashboard-next tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

@che-bot
Copy link
Contributor

che-bot commented Apr 8, 2021

❌ E2E dashboard-next tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants