Skip to content
This repository was archived by the owner on Jan 20, 2023. It is now read-only.

chore: update make branch workflow#58

Open
mkuznyetsov wants to merge 1 commit intomainfrom
make-branch
Open

chore: update make branch workflow#58
mkuznyetsov wants to merge 1 commit intomainfrom
make-branch

Conversation

@mkuznyetsov
Copy link
Contributor

Signed-off-by: Mykhailo Kuznietsov mkuznets@redhat.com

What does this PR do?

Update the workflow to use script from che-release repo

What issues does this PR fix or reference?

Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
@@ -1,3 +1,4 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line?

--branch ${{ github.event.inputs.branch }} \
--branchfrom ${{ github.event.inputs.branchfrom }} \
--repo "${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}" \
${{ github.event.inputs.forceflag }} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline

branchfrom:
description: 'The source branch from which to branch, eg., main'
default: 'master'
default: 'main'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is running on ubuntu-latest. Should that be 20.04 for consistency with all other build scripts?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants