feat(devfile): Generates devfile.yaml in addition to meta.yaml for che-editors and che-plugins

[benoitf]

What does this PR do?

Write devfile.yaml in addition to meta.yaml for che-plugins and che-editors

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Fixes eclipse-che/che#19060

How to test this PR?

Look at generated results in latest folder for example, it should include both meta.yaml and devfile.yaml

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Change-Id: Ibefbb93bc1eab00cdbfc1fe1e2ed2caac87166ce
Signed-off-by: Florent Benoit fbenoit@redhat.com

[codecov]

Codecov Report

Merging #853 (fae537a) into master (93f632c) will increase coverage by 0.69%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #853      +/-   ##
==========================================
+ Coverage   91.72%   92.41%   +0.69%     
==========================================
  Files          38       40       +2     
  Lines         955     1042      +87     
  Branches      108      129      +21     
==========================================
+ Hits          876      963      +87     
  Misses         79       79              

Impacted Files	Coverage Δ
tools/build/src/devfile/devfile-module.ts	100.00% <100.00%> (ø)
...ols/build/src/devfile/meta-yaml-to-devfile-yaml.ts	100.00% <100.00%> (ø)
tools/build/src/inversify-binding.ts	100.00% <100.00%> (ø)
tools/build/src/meta-yaml/index-writer.ts	100.00% <100.00%> (ø)
tools/build/src/meta-yaml/meta-yaml-writer.ts	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3504020...fae537a. Read the comment docs.

[sleshchenko]

LGTM

The only stuff that is missing: volumes components.
Comparing to devfile v1, volume mount is not enough, volume component should be declared explicitly, like for theia:

components:
- name: plugins
  volume: {}
- name: theia-local
  volume: {}
- name: remote-endpoint
  volume:
    ephemeral: true

Then plugins will not re-declare volume but just rely on the ones from Che Theia.

[benoitf]

@sleshchenko yes thanks, Angel told me about volumes yesterday.

Is that ephemeral is supported right now ?

[sleshchenko]

From Devfile API perspective - they are supported, from DevWorkspace Operator - they will be soon devfile/devworkspace-operator#281

[benoitf]

@sleshchenko ok but DevWorkspace Operator won't reject the file if ephemeral is used ?

[sleshchenko]

@sleshchenko ok but DevWorkspace Operator won't reject the file if ephemeral is used ?

I tried Angel's sample with ephemeral volume and no error is reported, workspace is started with PVC.

[benoitf]

PR updated with volumes generation

[sleshchenko]

LGTM

maybe it also makes sense to add devfile.yaml links into index.json

[benoitf]

devfile links added