Enable Che-Theia multi-root mode by default for all workspaces

[RomanNikitenko]

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

Notice: The changes should be merged together with eclipse-che/che#19406

What does this PR do?

The changes turn on the Multi-root mode by default for all workspaces.
It's possible to turn off the Multi-root mode by providing the corresponding value for multiRoot attribute:

attributes:
  multiRoot: 'off'

Screenshot/screencast of this PR

Multi-root is off:

Multi-root is on:

What issues does this PR fix or reference?

eclipse-che/che#19389

How to test this PR?

1. Start a workspace and check that the workspace has started in Multi-root mode by default.
2. Add the following to your devfile:

attributes:
  multiRoot: 'off'

3. Start the workspace and check that the Multi-root mode is off.

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

[RomanNikitenko]

[crw-ci-test]

[codecov]

Codecov Report

Merging #1053 (2125ff8) into master (eeb4526) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1053   +/-   ##
=======================================
  Coverage   29.45%   29.46%           
=======================================
  Files         277      277           
  Lines        9336     9333    -3     
  Branches     1380     1379    -1     
=======================================
  Hits         2750     2750           
+ Misses       6487     6484    -3     
  Partials       99       99           

Impacted Files	Coverage Δ
...e-theia-workspace/src/node/che-workspace-server.ts	0.00% <0.00%> (ø)
...workspace-plugin/src/workspace-projects-manager.ts	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeb4526...2125ff8. Read the comment docs.

[che-bot]

✅ E2E Happy path tests succeed 🎉

See Details

• Jenkins job console

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	quay.io/crw_pr/che-theia:1053
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1053

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

[azatsarynnyy]

I've quickly tested it with

Everything works as expected 👍
So, let's merge it ASAP. The beginning of the sprint is the best time for it! 🚀

[benoitf]

to fix devfile behavior with multi-root and plug-ins issue I've created

• feat(preferences): Allow to define preferences through environment variables #1047
• feat(preferences): Allow to define preferences in che-theia-plugins.yaml che-plugin-registry#904
• feat(preferences): Store preferences in che-theia-plugins.yaml file che-plugin-registry#905

first one have been merged

we can merge this PR now or when two PR on plug-in registry are merged as ruby and asciidoctor are not 'essential'