Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Conversation

@sleshchenko
Copy link
Member

@sleshchenko sleshchenko commented Apr 5, 2021

What does this PR do?

This PR adapts to workspace to devworkspace renaming on DWO side.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

It's done in the scope of devfile/devworkspace-operator#321.

It depends on devfile/devworkspace-operator#322

How to test this PR?

Test that Che Theia inside devworkspace works.
I haven't tested it since it depends on many other component changes, but changes are very simple.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

@codecov-io
Copy link

codecov-io commented Apr 5, 2021

Codecov Report

Merging #1065 (86c2c8f) into master (eeb4526) will increase coverage by 1.84%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
+ Coverage   29.45%   31.30%   +1.84%     
==========================================
  Files         277      277              
  Lines        9336     9354      +18     
  Branches     1380     1389       +9     
==========================================
+ Hits         2750     2928     +178     
+ Misses       6487     6329     -158     
+ Partials       99       97       -2     
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <ø> (ø)
...ovisioner/src/node/git-configuration-controller.ts 0.00% <0.00%> (ø)
...che-theia-remote-api/src/common/devfile-service.ts 0.00% <ø> (ø)
...ces/src/node/che-theia-preferences-synchronizer.ts 0.00% <0.00%> (ø)
...e-theia-workspace/src/node/che-workspace-server.ts 0.00% <0.00%> (ø)
generator/src/init-sources.ts 98.17% <ø> (ø)
...ainers-plugin/src/containers-tree-data-provider.ts 0.00% <0.00%> (ø)
plugins/task-plugin/src/task/che-task-runner.ts 0.00% <ø> (ø)
...che-server/src/node/che-server-k8s-service-impl.ts 39.13% <50.00%> (+39.13%) ⬆️
...server/src/node/che-server-devfile-service-impl.ts 86.56% <95.00%> (+4.79%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4e69f7...86c2c8f. Read the comment docs.

@azatsarynnyy
Copy link
Member

[crw-ci-test --rebuild]

@sleshchenko sleshchenko force-pushed the workspace2devworkspace branch from d9ba49e to 86c2c8f Compare April 8, 2021 10:49
@che-bot
Copy link
Contributor

che-bot commented Apr 8, 2021

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1065
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1065

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy path tests is not using that code anyway

@sleshchenko sleshchenko merged commit ed5b0a9 into eclipse-che:master Apr 8, 2021
@sleshchenko sleshchenko deleted the workspace2devworkspace branch April 8, 2021 13:15
@che-bot che-bot added this to the 7.29 milestone Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants