Fix for IDL bitmask type in cli tool #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Potman <dennis@zettascale.tech>
eboasson
approved these changes
Feb 22, 2023
Contributor
eboasson
left a comment
eboasson
left a comment
There was a problem hiding this comment.
The code change looks fine to me. The two failing CI tests appear completely unrelated, but they are worrisome. I'll merge this PR now and if you have some time to take a better look at those failures, that'd great.
Contributor
Author
Contributor
|
They are indeed the same failures, and indeed I have also never been able to reproduce them locally. I really do think that something suspicious is going on here, but I'm not sure how to proceed.... |
Contributor
|
Thanks @thijsmie! At least my immediate worry is alleviated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for printing bitmask types in the cli tool, in case any of the bitfields have the
@positionset.