-
Notifications
You must be signed in to change notification settings - Fork 30
Added dependency to JUnit 6 dependencies plug-in #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
why is this a draft? Should it be merged right away for the next SDK build? |
As mentioned in the other PR please dont just blindly merge those changes... |
Because its not ready yet, we still must do some other changes beforehand. |
|
See for next... |
I never merge anything blindly, therefore I've asked first why it is a draft
It would be nice if there would be some more info added in the PR what is missing. |
I created now |
|
So #146 renders this one useless, no? Or if the junit6.runtime has the deps the former is not needed? I somehow have the feeling that there are 2 competing efforts trying to achieve the same in 2 different ways. |
|
No ,this will still need if we implement a new runtime (what has to be investigated)... See it would help to just work from top-to-bottom instead of the other way round, when we then see something is not needed fine, but at the moment we just don't at this point. |
|
We'll have to wait some time I guess, for |
9af56b3 to
86048d2
Compare
|
https://download.eclipse.org/eclipse/downloads/drops4/I20251106-1300 is there, but the build still fails, |
|
@merks, @HannesWell, WDYT, just merge and see what next SDK build says? |
|
We can live a little dangerously to try to get to the finish line. |
Anyway I have the feeling next SDK build will fail (it will be Friday's build, and they always fail), so it wouldn't make much difference :) |
|
So pessimistic/realistic. 😭 |
I think so too.
Hope dies last :) |
See umbrella ticket for everything that is missing before we can merge this PR: #147