Skip to content

Conversation

@trancexpress
Copy link
Contributor

@trancexpress trancexpress commented Oct 8, 2025

See umbrella ticket for everything that is missing before we can merge this PR: #147

@iloveeclipse
Copy link
Member

why is this a draft? Should it be merged right away for the next SDK build?

@laeubi
Copy link
Contributor

laeubi commented Oct 24, 2025

why is this a draft? Should it be merged right away for the next SDK build?

As mentioned in the other PR please dont just blindly merge those changes...

@trancexpress
Copy link
Contributor Author

why is this a draft? Should it be merged right away for the next SDK build?

Because its not ready yet, we still must do some other changes beforehand.

@laeubi
Copy link
Contributor

laeubi commented Oct 24, 2025

See

for next...

@iloveeclipse
Copy link
Member

As mentioned in the other PR please dont just blindly merge those changes...

I never merge anything blindly, therefore I've asked first why it is a draft

Because its not ready yet, we still must do some other changes beforehand.

It would be nice if there would be some more info added in the PR what is missing.

@laeubi
Copy link
Contributor

laeubi commented Oct 24, 2025

It would be nice if there would be some more info added in the PR what is missing.

I created now

@akurtakov
Copy link
Contributor

akurtakov commented Oct 24, 2025

So #146 renders this one useless, no? Or if the junit6.runtime has the deps the former is not needed? I somehow have the feeling that there are 2 competing efforts trying to achieve the same in 2 different ways.

@laeubi
Copy link
Contributor

laeubi commented Oct 24, 2025

No ,this will still need if we implement a new runtime (what has to be investigated)...

See

it would help to just work from top-to-bottom instead of the other way round, when we then see something is not needed fine, but at the moment we just don't at this point.

@trancexpress trancexpress marked this pull request as ready for review November 4, 2025 17:26
@trancexpress
Copy link
Contributor Author

We'll have to wait some time I guess, for org.eclipse.jdt.junit6.runtime to be available:

Error:  Cannot resolve dependencies of project org.eclipse.jdt.feature:org.eclipse.jdt:eclipse-feature:3.20.500-SNAPSHOT
Error:   with context {osgi.os=linux, osgi.ws=gtk, org.eclipse.update.install.features=true, org.eclipse.jdt.buildtime=true, osgi.arch=x86_64, org.eclipse.update.install.sources=true}
Error:    Software being installed: org.eclipse.jdt.feature.group 3.20.500.qualifier
Error:    Missing requirement: org.eclipse.jdt.feature.group 3.20.500.qualifier requires 'org.eclipse.equinox.p2.iu; org.eclipse.jdt.junit6.runtime 0.0.0' but it could not be found: See log for 

@trancexpress trancexpress force-pushed the junit6 branch 2 times, most recently from 9af56b3 to 86048d2 Compare November 5, 2025 11:30
@iloveeclipse
Copy link
Member

https://download.eclipse.org/eclipse/downloads/drops4/I20251106-1300 is there, but the build still fails,
see
https://ci.eclipse.org/jdt/job/eclipse.jdt-github/job/PR-145/12/console
@akurtakov , @laeubi : I believe this is chicken and egg issue, could it be?

@iloveeclipse
Copy link
Member

@merks, @HannesWell, WDYT, just merge and see what next SDK build says?

@merks
Copy link
Contributor

merks commented Nov 6, 2025

We can live a little dangerously to try to get to the finish line.

@iloveeclipse
Copy link
Member

We can live a little dangerously to try to get to the finish line.

Anyway I have the feeling next SDK build will fail (it will be Friday's build, and they always fail), so it wouldn't make much difference :)

@merks
Copy link
Contributor

merks commented Nov 6, 2025

So pessimistic/realistic. 😭

@iloveeclipse iloveeclipse merged commit 1bca4d5 into eclipse-jdt:master Nov 6, 2025
3 of 5 checks passed
@HannesWell
Copy link
Contributor

I believe this is chicken and egg issue, could it be?

I think so too. org.eclipse.jdt.junit6.runtime isn't in the build repository, which absolutely makes sense if nothing pulls it in.
So this is required to succeed...

it will be Friday's build, and they always fail

Hope dies last :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants