handle attribute with text equal to single quote (i.e. ") #1726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attribute method is not able to handle the string with a single quote. We trim the quotes from the string without checking its length, and it's causing an issue if string has only one character. e.g. val="
Contributor
|
@hmittal1 thanks so much for your contribution. Could you fill the ECA please. |
Contributor
Author
Done. |
Contributor
|
Thank you for this good PR! |
Contributor
|
Thanks @hmittal1 ! |
Contributor
Author
|
@angelozerr may i know when are you planning to push the next release with this fix ? |
Contributor
|
I am sorry but I don't know since we have just your fix https://github.com/eclipse-lemminx/lemminx/milestone/46?closed=1 for the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attribute method is not able to handle the string with a single quote. We trim the quotes from the string without checking its length, and it's causing an issue if string has only one character. e.g. val="