-
Notifications
You must be signed in to change notification settings - Fork 19
Add dcp support fixes for Linux/Docker #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: add_dcp_support
Are you sure you want to change the base?
Add dcp support fixes for Linux/Docker #28
Conversation
…oes not exist. Decided to skip comparing results.
|
For further information you might also want to look into the logs and binaries attached here: |
|
Some irreproducible error might happen after With an Error that a timeout was reached. Changing the Master::timeout_ to a higher value and recompiling the openmcx binary removed the error permanently. master.cpp:577:process_response:"//check whether the timeout was reached" |
| if(ENABLE_DCP) | ||
| find_package(xercesc REQUIRED) | ||
| if(UNIX) | ||
| find_package(XercesC REQUIRED) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't it be enough to just use this for both platforms?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot say for sure, because I do not have the (same) resources at the moment to test this the way you test it.
I decided to make a non-invasive change.
I know from my last commit that vcpkg occasionally uses different names and naming-schemes for packages than other package management systems and that the generated CMake-related files may not be working with the default names.
Necessary fixes to be able to build it on Linux/podman(alias docker)
Built and Tests ran in a container using podman.
Replace any
podmanoccurences withdockerand you should be fine.Also make sure the file
install/dcp/cosine/slave.dcpxexists before running any tests.Find scripts attached:
helperscripts.zip