Skip to content

Caught the exception when a version is malformed in target file #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nburnwal09 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Caught the exception when a version is malformed in target file #2157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/PDEUIMessages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3212,6 +3212,8 @@ public class PDEUIMessages extends NLS {

public static String TargetEditor_6;

public static String TargetEditor_7;

public static String FeatureImportWizardPage_importHasInvalid;

public static String ProductInfoSection_plugins;
Expand Down
7 changes: 7 additions & 0 deletions ....eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/targetdefinition/TargetEditor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,10 @@ protected void pageChange(int newPageIndex) {
setActivePage(fSourceTabIndex);
CoreException ce = new CoreException(Status.error(e.getMessage(), e));
showError(PDEUIMessages.TargetEditor_5, ce);
} catch (IllegalArgumentException e) {
setActivePage(fSourceTabIndex);
CoreException ce = new CoreException(Status.error(e.getMessage(), e));
showError(PDEUIMessages.TargetEditor_7, ce);
}
}

Expand Down Expand Up @@ -560,6 +564,9 @@ private ITargetDefinition loadTargetDefinition() throws CoreException {
} catch (CoreException e) {
fTarget = service.newTarget();
throw e;
} catch (IllegalArgumentException e) {
fTarget = service.newTarget();
throw new CoreException(Status.error(e.getMessage(), e));
}
PlatformUI.getWorkbench().getDisplay().asyncExec(
() -> TargetEditor.this.getTargetChangedListener().contentsChanged(fTarget, this, true, false));
Expand Down
1 change: 1 addition & 0 deletions ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1994,6 +1994,7 @@ TargetEditor_3=Unable to perform save
TargetEditor_4=Target Editor
TargetEditor_5=Unable to load target definition model. Fix the target definition model in Source View.
TargetEditor_6=The editor input ''{0}'' is not supported.
TargetEditor_7=Unable to parse the IU version
TargetCreationPage_0=Initialize the target definition with:
TargetCreationPage_1=Nothing: Start &with an empty target definition
TargetCreationPage_2=&Default: Default target for the running platform
Expand Down
Loading