log: `mw_log` implementation #32

arkjedrz · 2025-12-11T07:58:39Z

Replacement for log crate.
Additional common types implementation.
Selectable safety level features.
Unit tests.

Notes for Reviewer

Pre-Review Checklist for the PR Author

PR title is short, expressive and meaningful
Commits are properly organized
Relevant issues are linked in the References section
Tests are conducted
Unit tests are added

Checklist for the PR Reviewer

Commits are properly organized and messages are according to the guideline
Unit tests have been written for new behavior
Public API is documented
PR title describes the changes

Post-review Checklist for the PR Author

All open points are addressed and tracked via issues

References

Closes #30

github-actions · 2025-12-11T07:59:29Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: db872f57-44c9-45bc-8a33-8406bdf4b793
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-eQOopREOYCL5vtTb6c1cwZrql4GVrJ1FqgxarQRe1xs="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.8.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.1.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@1.5.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.2.0.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_docs_as_code', the root module requires module version score_docs_as_code@2.0.2, but got score_docs_as_code@2.2.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (33 packages loaded, 10 targets configured)

Analyzing: target //:license-check (131 packages loaded, 529 targets configured)

Analyzing: target //:license-check (147 packages loaded, 1835 targets configured)

Analyzing: target //:license-check (147 packages loaded, 1835 targets configured)

Analyzing: target //:license-check (152 packages loaded, 4833 targets configured)

Analyzing: target //:license-check (155 packages loaded, 8887 targets configured)

Analyzing: target //:license-check (155 packages loaded, 8887 targets configured)

INFO: Analyzed target //:license-check (156 packages loaded, 9013 targets configured).
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 4 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 32.672s, Critical Path: 0.55s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2025-12-11T08:01:11Z

The created documentation from the pull request is available at: docu-html

Copilot

Pull request overview

This PR implements the mw_log logging facade as a replacement for the log crate, providing a custom logging interface with formatting capabilities.

Key changes:

New mw_log library with logging macros, levels, and traits
Updated module references from mw_log_fmt to mw_log::fmt throughout the codebase
Enhanced mw_log_fmt with additional type implementations and test coverage

Reviewed changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/log/mw_log/lib.rs	Core logging implementation with Level, LevelFilter, Log trait, and Record/Metadata types
src/log/mw_log/macros.rs	Logging macros (log!, fatal!, error!, warn!, info!, debug!, trace!, log_enabled!)
src/log/mw_log/__private_api.rs	Internal API for macro support including log, enabled, context, and location helpers
src/log/mw_log/tests/*.rs	Unit and integration tests for logging functionality
src/log/mw_log_fmt_macro/*.rs	Updated module paths from `mw_log_fmt::` to `mw_log::fmt::`
src/log/mw_log_fmt/fmt_impl.rs	Added ScoreDebug implementations for (), str, Option, HashMap, error types
src/log/mw_log_fmt/test_utils.rs	Updated test helper to set DisplayHint::Debug for consistent formatting
examples/log_example/*	Example application demonstrating logger implementation
Build files (BUILD, Cargo.toml)	Updated dependencies and visibility settings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/log/BUILD

src/log/mw_log/lib.rs

Copilot

Pull request overview

Copilot reviewed 25 out of 26 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/log/mw_log_fmt_macro/format_args.rs

src/log/mw_log/lib.rs

Copilot

Pull request overview

Copilot reviewed 25 out of 26 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pawelrutkaq

did not looke into macros yet

src/log/mw_log_fmt_macro/Cargo.toml

src/log/mw_log_fmt/Cargo.toml

src/log/mw_log/lib.rs

src/log/mw_log/__private_api.rs

src/log/mw_log/tests/macros.rs

src/log/mw_log/Cargo.toml

src/log/mw_log/lib.rs

src/log/mw_log/macros.rs

Copilot

Pull request overview

Copilot reviewed 26 out of 27 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pawelrutkaq · 2025-12-29T09:14:49Z

src/log/mw_log/lib.rs

+    }
+}
+
+impl<T: ?Sized + Log> Log for std::sync::Arc<T> {


not needed ?

pawelrutkaq · 2025-12-29T09:15:11Z

src/log/mw_log/lib.rs

+    }
+}
+
+impl<T: ?Sized + Log> Log for std::boxed::Box<T> {


alloc::boxed::Box ? and other places?

- Replacement for `log` crate. - Additional common types implementation. - Selectable safety level features (`asil_b`, `qm`). - Unit tests.

arkjedrz force-pushed the arkjedrz_mw-log-main branch 6 times, most recently from 550ccf3 to a65f5cb Compare December 15, 2025 14:48

arkjedrz mentioned this pull request Dec 15, 2025

Improvement: Add qm crate feature option for Bazel #30

Closed

arkjedrz force-pushed the arkjedrz_mw-log-main branch 2 times, most recently from ad3ef67 to 39a84b6 Compare December 16, 2025 13:25

arkjedrz self-assigned this Dec 16, 2025

arkjedrz force-pushed the arkjedrz_mw-log-main branch 3 times, most recently from 7e98e5d to b6c4efb Compare December 18, 2025 11:25

arkjedrz temporarily deployed to workflow-approval December 18, 2025 11:25 — with GitHub Actions Inactive

arkjedrz marked this pull request as ready for review December 18, 2025 11:38

arkjedrz requested review from awillenbuecher-xq-tec, Copilot and pawelrutkaq December 18, 2025 11:38

Copilot AI reviewed Dec 18, 2025

View reviewed changes

src/log/BUILD Outdated Show resolved Hide resolved

src/log/mw_log/lib.rs Outdated Show resolved Hide resolved

arkjedrz force-pushed the arkjedrz_mw-log-main branch from b6c4efb to 486f04c Compare December 18, 2025 12:10

arkjedrz temporarily deployed to workflow-approval December 18, 2025 12:10 — with GitHub Actions Inactive

arkjedrz requested a review from Copilot December 18, 2025 12:10

Copilot AI reviewed Dec 18, 2025

View reviewed changes

src/log/mw_log_fmt_macro/format_args.rs Show resolved Hide resolved

src/log/mw_log/lib.rs Outdated Show resolved Hide resolved

src/log/mw_log/lib.rs Outdated Show resolved Hide resolved

src/log/mw_log/lib.rs Outdated Show resolved Hide resolved

arkjedrz force-pushed the arkjedrz_mw-log-main branch from 486f04c to 46ccd6a Compare December 18, 2025 12:22

arkjedrz temporarily deployed to workflow-approval December 18, 2025 12:22 — with GitHub Actions Inactive

arkjedrz requested a review from Copilot December 18, 2025 12:24

Copilot AI reviewed Dec 18, 2025

View reviewed changes

pawelrutkaq requested changes Dec 18, 2025

View reviewed changes

arkjedrz force-pushed the arkjedrz_mw-log-main branch from 27790b3 to 714137f Compare December 22, 2025 13:01

arkjedrz temporarily deployed to workflow-approval December 22, 2025 13:01 — with GitHub Actions Inactive

pawelrutkaq requested changes Dec 23, 2025

View reviewed changes

arkjedrz force-pushed the arkjedrz_mw-log-main branch from 714137f to c38cec7 Compare December 23, 2025 12:37

arkjedrz temporarily deployed to workflow-approval December 23, 2025 12:37 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_mw-log-main branch from c38cec7 to 8cad2a7 Compare December 23, 2025 12:45

arkjedrz had a problem deploying to workflow-approval December 23, 2025 12:45 — with GitHub Actions Failure

arkjedrz requested review from Copilot and pawelrutkaq and removed request for Copilot December 23, 2025 12:45

Copilot AI reviewed Dec 23, 2025

View reviewed changes

arkjedrz force-pushed the arkjedrz_mw-log-main branch from 8cad2a7 to e03b248 Compare December 23, 2025 13:52

arkjedrz temporarily deployed to workflow-approval December 23, 2025 13:52 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_mw-log-main branch from e03b248 to bc26f4e Compare December 23, 2025 14:15

arkjedrz had a problem deploying to workflow-approval December 23, 2025 14:15 — with GitHub Actions Failure

arkjedrz had a problem deploying to workflow-approval December 23, 2025 14:23 — with GitHub Actions Failure

arkjedrz force-pushed the arkjedrz_mw-log-main branch from bc26f4e to 27d9b22 Compare December 29, 2025 07:31

arkjedrz temporarily deployed to workflow-approval December 29, 2025 07:31 — with GitHub Actions Inactive

arkjedrz had a problem deploying to workflow-approval December 29, 2025 08:45 — with GitHub Actions Failure

arkjedrz had a problem deploying to workflow-approval December 29, 2025 08:48 — with GitHub Actions Failure

arkjedrz force-pushed the arkjedrz_mw-log-main branch from 27d9b22 to c6ba882 Compare December 29, 2025 08:49

arkjedrz temporarily deployed to workflow-approval December 29, 2025 08:49 — with GitHub Actions Inactive

pawelrutkaq requested changes Dec 29, 2025

View reviewed changes

log: mw_log implementation

abcfec9

- Replacement for `log` crate. - Additional common types implementation. - Selectable safety level features (`asil_b`, `qm`). - Unit tests.

arkjedrz force-pushed the arkjedrz_mw-log-main branch from c6ba882 to abcfec9 Compare December 29, 2025 09:38

arkjedrz temporarily deployed to workflow-approval December 29, 2025 09:38 — with GitHub Actions Inactive

pawelrutkaq approved these changes Dec 29, 2025

View reviewed changes

pawelrutkaq merged commit 268b5c9 into eclipse-score:main Dec 29, 2025
12 checks passed

arkjedrz deleted the arkjedrz_mw-log-main branch December 29, 2025 09:42

log: mw_log implementation #32

log: mw_log implementation #32

Uh oh!

Conversation

arkjedrz commented Dec 11, 2025 • edited by pawelrutkaq Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notes for Reviewer

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

References

Uh oh!

github-actions bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions bot commented Dec 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

pawelrutkaq left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

pawelrutkaq Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

log: `mw_log` implementation #32

log: `mw_log` implementation #32

arkjedrz commented Dec 11, 2025 •

edited by pawelrutkaq

Loading

github-actions bot commented Dec 11, 2025 •

edited

Loading