-
Notifications
You must be signed in to change notification settings - Fork 3
log: Rust-based backend implementation #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: Rust-based backend implementation #39
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
2714ca1 to
62d7653
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements a Rust-based logging backend for the mw_log system. The implementation provides a core logging facade (mw_log), a string-based logger subscriber (mw_log_subscriber), and updates to existing formatting infrastructure to support the new logging system.
Key changes:
- Introduction of
mw_loglibrary providing logging macros and core logging traits - Addition of
mw_log_subscriberwith a string-based backend implementation - Updated module visibility and dependencies across logging components
- Addition of example applications demonstrating both custom and built-in logger usage
Reviewed changes
Copilot reviewed 31 out of 32 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/log/mw_log/lib.rs |
Core logging facade with Level, LevelFilter, Log trait, and logging infrastructure |
src/log/mw_log/macros.rs |
Logging macros (log!, trace!, debug!, info!, warn!, error!, fatal!) |
src/log/mw_log/__private_api.rs |
Private API helpers for macro expansion |
src/log/mw_log_subscriber/lib.rs |
String-based logger implementation with builder pattern |
src/log/mw_log_fmt_macro/format_args.rs |
Updated module references from mw_log_fmt to mw_log::fmt |
src/log/mw_log_fmt_macro/score_debug.rs |
Updated module references from mw_log_fmt to mw_log::fmt |
src/log/mw_log_fmt/fmt_impl.rs |
Added ScoreDebug implementations for common types (Option, HashMap, errors) |
src/log/mw_log_fmt/test_utils.rs |
Updated test utility to use DisplayHint::Debug |
src/log/mw_log_fmt/BUILD |
Updated visibility constraints and added feature flags |
examples/log_builtin/src/main.rs |
Example demonstrating built-in logger usage |
examples/log_custom/src/logger.rs |
Example demonstrating custom logger implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
62d7653 to
0a425a6
Compare
0a425a6 to
4041922
Compare
4041922 to
9377d88
Compare
9377d88 to
60a94b9
Compare
60a94b9 to
5f449ba
Compare
5f449ba to
972528e
Compare
972528e to
5f449ba
Compare
5f449ba to
d31fb8e
Compare
pawelrutkaq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will wait to merge previous one to fo finish this.
d31fb8e to
5b3fcf1
Compare
5b3fcf1 to
38dd0d2
Compare
38dd0d2 to
42ef9d6
Compare
42ef9d6 to
01c0052
Compare
01c0052 to
06cb8e2
Compare
06cb8e2 to
8366254
Compare
8366254 to
6a4bc74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Basic implementation creating a string, printed to stderr.
6a4bc74 to
5c2b8b0
Compare
pawelrutkaq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Basic implementation creating a string, printed to stderr.
Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #