Skip to content

Conversation

@arkjedrz
Copy link
Contributor

@arkjedrz arkjedrz commented Dec 17, 2025

Basic implementation creating a string, printed to stderr.

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • PR title is short, expressive and meaningful
  • Commits are properly organized
  • Relevant issues are linked in the References section
  • Tests are conducted
  • Unit tests are added

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #

@github-actions
Copy link

github-actions bot commented Dec 17, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: b717acc2-e40f-47a2-bb60-83e92781d14e
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-eQOopREOYCL5vtTb6c1cwZrql4GVrJ1FqgxarQRe1xs="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
Computing main repo mapping: 
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.8.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.1.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@1.5.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.2.0.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_docs_as_code', the root module requires module version score_docs_as_code@2.0.2, but got score_docs_as_code@2.2.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (31 packages loaded, 10 targets configured)

Analyzing: target //:license-check (127 packages loaded, 461 targets configured)

Analyzing: target //:license-check (147 packages loaded, 2719 targets configured)

Analyzing: target //:license-check (150 packages loaded, 2730 targets configured)

Analyzing: target //:license-check (150 packages loaded, 2730 targets configured)

INFO: Analyzed target //:license-check (156 packages loaded, 9013 targets configured).
[1 / 1] no actions running
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 4 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 22.925s, Critical Path: 0.35s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@arkjedrz arkjedrz self-assigned this Dec 17, 2025
@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-subscriber branch from 2714ca1 to 62d7653 Compare December 18, 2025 12:35
@arkjedrz arkjedrz temporarily deployed to workflow-approval December 18, 2025 12:35 — with GitHub Actions Inactive
@arkjedrz arkjedrz requested a review from Copilot December 18, 2025 12:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a Rust-based logging backend for the mw_log system. The implementation provides a core logging facade (mw_log), a string-based logger subscriber (mw_log_subscriber), and updates to existing formatting infrastructure to support the new logging system.

Key changes:

  • Introduction of mw_log library providing logging macros and core logging traits
  • Addition of mw_log_subscriber with a string-based backend implementation
  • Updated module visibility and dependencies across logging components
  • Addition of example applications demonstrating both custom and built-in logger usage

Reviewed changes

Copilot reviewed 31 out of 32 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/log/mw_log/lib.rs Core logging facade with Level, LevelFilter, Log trait, and logging infrastructure
src/log/mw_log/macros.rs Logging macros (log!, trace!, debug!, info!, warn!, error!, fatal!)
src/log/mw_log/__private_api.rs Private API helpers for macro expansion
src/log/mw_log_subscriber/lib.rs String-based logger implementation with builder pattern
src/log/mw_log_fmt_macro/format_args.rs Updated module references from mw_log_fmt to mw_log::fmt
src/log/mw_log_fmt_macro/score_debug.rs Updated module references from mw_log_fmt to mw_log::fmt
src/log/mw_log_fmt/fmt_impl.rs Added ScoreDebug implementations for common types (Option, HashMap, errors)
src/log/mw_log_fmt/test_utils.rs Updated test utility to use DisplayHint::Debug
src/log/mw_log_fmt/BUILD Updated visibility constraints and added feature flags
examples/log_builtin/src/main.rs Example demonstrating built-in logger usage
examples/log_custom/src/logger.rs Example demonstrating custom logger implementation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-subscriber branch from 62d7653 to 0a425a6 Compare December 19, 2025 14:46
@arkjedrz arkjedrz temporarily deployed to workflow-approval December 19, 2025 14:46 — with GitHub Actions Inactive
@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-subscriber branch from 0a425a6 to 4041922 Compare December 22, 2025 07:33
@arkjedrz arkjedrz temporarily deployed to workflow-approval December 22, 2025 07:33 — with GitHub Actions Inactive
@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-subscriber branch from 4041922 to 9377d88 Compare December 22, 2025 11:08
@arkjedrz arkjedrz temporarily deployed to workflow-approval December 22, 2025 11:08 — with GitHub Actions Inactive
@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-subscriber branch from 9377d88 to 60a94b9 Compare December 22, 2025 12:01
@arkjedrz arkjedrz temporarily deployed to workflow-approval December 22, 2025 12:01 — with GitHub Actions Inactive
@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-subscriber branch from 60a94b9 to 5f449ba Compare December 22, 2025 12:25
@arkjedrz arkjedrz temporarily deployed to workflow-approval December 22, 2025 12:26 — with GitHub Actions Inactive
@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-subscriber branch from 5f449ba to 972528e Compare December 22, 2025 13:03
@arkjedrz arkjedrz temporarily deployed to workflow-approval December 22, 2025 13:03 — with GitHub Actions Inactive
@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-subscriber branch from 972528e to 5f449ba Compare December 22, 2025 13:34
@arkjedrz arkjedrz temporarily deployed to workflow-approval December 22, 2025 13:34 — with GitHub Actions Inactive
@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-subscriber branch from 5f449ba to d31fb8e Compare December 23, 2025 11:47
@arkjedrz arkjedrz temporarily deployed to workflow-approval December 23, 2025 11:47 — with GitHub Actions Inactive
Copy link
Contributor

@pawelrutkaq pawelrutkaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will wait to merge previous one to fo finish this.

@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-subscriber branch from d31fb8e to 5b3fcf1 Compare December 29, 2025 07:47
@arkjedrz arkjedrz temporarily deployed to workflow-approval December 29, 2025 07:47 — with GitHub Actions Inactive
@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-subscriber branch from 5b3fcf1 to 38dd0d2 Compare December 29, 2025 08:02
@arkjedrz arkjedrz temporarily deployed to workflow-approval December 29, 2025 08:02 — with GitHub Actions Inactive
@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-subscriber branch from 38dd0d2 to 42ef9d6 Compare December 29, 2025 08:03
@arkjedrz arkjedrz temporarily deployed to workflow-approval December 29, 2025 08:03 — with GitHub Actions Inactive
@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-subscriber branch from 42ef9d6 to 01c0052 Compare December 29, 2025 09:35
@arkjedrz arkjedrz temporarily deployed to workflow-approval December 29, 2025 09:35 — with GitHub Actions Inactive
@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-subscriber branch from 01c0052 to 06cb8e2 Compare December 29, 2025 09:40
@arkjedrz arkjedrz temporarily deployed to workflow-approval December 29, 2025 09:40 — with GitHub Actions Inactive
@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-subscriber branch from 06cb8e2 to 8366254 Compare December 29, 2025 09:43
@arkjedrz arkjedrz temporarily deployed to workflow-approval December 29, 2025 09:43 — with GitHub Actions Inactive
@arkjedrz arkjedrz marked this pull request as ready for review December 29, 2025 09:43
@arkjedrz arkjedrz requested a review from pawelrutkaq December 29, 2025 09:46
@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-subscriber branch from 8366254 to 6a4bc74 Compare December 29, 2025 11:16
@arkjedrz arkjedrz temporarily deployed to workflow-approval December 29, 2025 11:16 — with GitHub Actions Inactive
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Basic implementation creating a string, printed to stderr.
@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-subscriber branch from 6a4bc74 to 5c2b8b0 Compare December 29, 2025 11:19
@arkjedrz arkjedrz temporarily deployed to workflow-approval December 29, 2025 11:19 — with GitHub Actions Inactive
Copy link
Contributor

@pawelrutkaq pawelrutkaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pawelrutkaq pawelrutkaq merged commit fd17433 into eclipse-score:main Dec 29, 2025
12 checks passed
@arkjedrz arkjedrz deleted the arkjedrz_mw-log-subscriber branch December 29, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants